Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logs: fix clipping configuration #1934

Merged
merged 2 commits into from
Jan 14, 2021
Merged

Conversation

tonistiigi
Copy link
Member

noticed on docker/setup-buildx-action#50

Also increase defaults 2x

@crazy-max

@LukeIreland1
Copy link

When is this going to be added to a buildkit release?

@joseluisq
Copy link

Also still facing the mentioned issue on Docker 20.10.11.

@ashirazi2
Copy link

Unless I'm missing something, this PR does not update the message that the end user sees, even though it has been bumped to 2MiB.

A more useful solution would be to change logging to provide a scrollback of 1MiB. As developers, we want to see the most recent log messages when something fails. Not the first 1MiB of messages when everything was building fine.

@felipecrs
Copy link

felipecrs commented Apr 4, 2022

@crazy-max is it possible to configure this in the /etc/docker/daemon.json or anywhere else to be applied system-widely?

@tonistiigi
Copy link
Member Author

As developers, we want to see the most recent log messages when something fails. Not the first 1MiB of messages when everything was building fine.

This was added in v0.10 #2577

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants