keep buffer of logs to show on failure when regular logs are clipped #2577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
reviewed
Jan 25, 2022
go.mod
Outdated
| @@ -78,6 +78,8 @@ require ( | |||
| google.golang.org/grpc v1.42.0 | |||
| ) | |||
|
|
|||
| require github.com/armon/circbuf v0.0.0-20150827004946-bbbad097214e | |||
There was a problem hiding this comment.
This should be placed in the main require() block?
There was a problem hiding this comment.
Do you know if we are doing anything wrong so that this isn't added to the correct place automatically?
Signed-off-by: Tonis Tiigi <[email protected]>
tonistiigi
force-pushed
the
log-clip-buffer
branch
from
f62d4b5 to
ffce821
Compare
AkihiroSuda
approved these changes
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2573
Signed-off-by: Tonis Tiigi [email protected]