Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding more character options to plugins and templates #15348

Closed
wants to merge 2 commits into from
Closed

Adding more character options to plugins and templates #15348

wants to merge 2 commits into from

Conversation

matdave
Copy link
Contributor

@matdave matdave commented Dec 11, 2020

What does it do?

Expands the qualifying character patterns for Templates and Plugins names to prevent breaking sites during upgrade.

Why is it needed?

PR #15146 reduced the available characters in these non-callable element names. This breaks older sites that used common character patterns in their names.

How to test

Attempt to add additional strings to a plugin or template names. It still blocks callable code, but allows commonly used special characters.

Related issue(s)/PR(s)

issue #15323

Edited: clarified these are referring to the names of the elements

@cla-bot cla-bot bot added the cla-signed CLA confirmed for contributors to this PR. label Dec 11, 2020
Copy link
Member

@opengeek opengeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to the map files must be made in the schema and generated to the map files. These changes will otherwise be overwritten the next time the schema is parsed.

@matdave
Copy link
Contributor Author

matdave commented Dec 11, 2020

D'oh... done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA confirmed for contributors to this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants