Fix Plugin and Template name validation #15349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaLuckers
approved these changes
Jan 12, 2021
JoshuaLuckers
added
pr/ready-for-merging
The schema files could not be used to regenerate the map files because < is not allowed in XML attribute values. Replaced with the < entity to resolve.
opengeek
force-pushed
the
fix-plugin-template-validation
branch
from
9f949f6 to
6765692
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Expands the qualifying character patterns for Template and Plugin names to prevent breaking sites during upgrade.
Why is it needed?
PR #15146 reduced the available characters in these non-callable element names. This breaks older sites that used common character patterns in their names.
How to test
Attempt to add additional strings to a plugin or template names. It still blocks callable code, but allows commonly used special characters.
Related issue(s)/PR(s)
issue #15323
supercedes #15348