Add support for Java 11 and test with Maven 3.6.0 #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We also hit it in the Jenkins project: https://issues.jenkins-ci.org/browse/JENKINS-54843 (CC @batmat @alecharp). I can workaround it there, but a release would be nice |
| @@ -84,6 +84,9 @@ | |||
| // Java10 | |||
| JDK_TO_MAJOR_VERSION_NUMBER_MAPPING.put( "1.10", 54 ); | |||
| JDK_TO_MAJOR_VERSION_NUMBER_MAPPING.put( "10", 54 ); | |||
|
|
|||
| // Java11 | |||
| JDK_TO_MAJOR_VERSION_NUMBER_MAPPING.put( "11", 55 ); | |||
There was a problem hiding this comment.
Makes sense to put Java 12 as well. It is already in early access
oleg-nenashev
approved these changes
Nov 23, 2018
4 tasks
|
FTR, I've assigned this to myself to get it over the fence. Also just started a vote on the mojohaus-dev ML to release mojo-parent:50, which I plan to use in a followup to bump to Java 7 minimum (once/if the vote passes). I've no idea how AppVeyor is supposed to run/check things here. Apparently, there's been no PR build from this service, for some reason. Also going to do small adjustments. |
This fails with JDK11. Checking this in to see if I can get a green PR build without this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #61
Travis CI tests with cobertura reports failed with Java 11 due to not existing tools.jar - probably this plugin should be excluded from the build.