Also support 1.x version schemes #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Despite https://openjdk.java.net/jeps/223 officially deprecating 1.x schemes, we should be permissive here to avoid crashes. For instance, in Jenkins the version in use is `1.${java.level}`. https://github.com/jenkinsci/plugin-pom/blob/master/pom.xml#L522 So supporting both formats will avoid unnecessary headaches around. We'll see possibly in the future to stop supporting this when the oldest line is >=9 and no more 1.x format can exist.
|
No opinion. My preference would be to require all users to pass the version numbers correctly as documented by https://openjdk.java.net/jeps/223. But this patch simplifies the adoption OTOH |
|
so you mean we should remove the As the plugin has supported 1.x and x since 1.6, I think this should be fine. But I won't feel confident until we've checked :-) |
|
@batmat Yes, I am doing it in jenkinsci/plugin-pom#133 |
Given we use a LinkedHashMap, then we're guaranteed to find the first inserted occurrence. Not a big deal anyway since this is (and shouldn't in general) only cared about the `renderVersion` related test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small followup on #63 and #64
Despite https://openjdk.java.net/jeps/223 officially deprecating 1.x schemes, we should be permissive here to avoid crashes.
For instance, in Jenkins the version in use is
1.${java.level}.https://github.com/jenkinsci/plugin-pom/blob/master/pom.xml#L522
So supporting both formats will avoid unnecessary headaches around. We'll see possibly in the future to stop supporting this when the oldest line is >=9 and no more 1.x format can exist.
cc @jenkinsci/java11-support