Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Clingen subset to release products #8530

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Conversation

matentzn
Copy link
Member

@matentzn matentzn commented Jan 5, 2025

And do a bit of SUBSETDIR refactoring in the Makefile.

image

Suprising that was never noticed: the SUBSETDIR variable used here was never declared..
Basically, take the labels, and swap them out for clingen preferred labels
Copy link
Collaborator

@twhetzel twhetzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! questions/comments inline

}
FILTER NOT EXISTS {
?cls owl:deprecated "true"^^xsd:boolean
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should obsolete terms be excluded? There are obsolete Mondo terms that have the clingen subset annotation. Is there some other way that ClinGen is notified of obsolete Mondo terms in the clingen subset?

Edit: Although after running the new goal (sh run.sh make subsets/mondo-clingen.owl -B) obsolete terms in the clingen subset are in mondo-clingen.owl.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there some other way that ClinGen is notified of obsolete Mondo terms in the clingen subset?

The primary way some people in clingen learn of this is through:

https://github.com/monarch-initiative/mondo/blob/master/src/ontology/reports/mondo_obsoletioncandidates.tsv

and

https://github.com/monarch-initiative/mondo/blob/master/src/ontology/reports/mondo_release_diff_changed_terms.tsv

They read those files with every release and supposedly generate curation instructions based on these.

Edit: Although after running the new goal (sh run.sh make subsets/mondo-clingen.owl -B) obsolete terms in the clingen subset are in mondo-clingen.owl.

Hmm.. Both questions (why is it in and should it be in) are good questions we need to answer in an upcoming meeting.

owl:annotatedSource ?entity ;
owl:annotatedProperty oboInOwl:hasExactSynonym ;
owl:annotatedTarget ?label ;
oboInOwl:hasSynonymType <http://purl.obolibrary.org/obo/mondo#MONDO_LABEL> .
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This http://purl.obolibrary.org/obo/mondo#MONDO_LABEL does not exist as a synonym_type_property.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, there is no synonym type for that "idea" (the "label" used in Mondo). This is an ad-hoc synonym type just for this subset!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants