-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python version extraction breaks if a trailing space exists #43
Comments
I may have a chance to contribute a patch, but wanted to put this up in case someone else gets to it first! |
Oh, that's a good catch. I wonder if adjusting -PYTHON_RUNTIME_VERSION="$(sed -n -e '/^\[metadata\]/,/^\[/p' poetry.lock | sed -n -e 's/^python-versions\s*=\s*//p' | tr -d \"\')"
+PYTHON_RUNTIME_VERSION="$(sed -n -e '/^\[metadata\]/,/^\[/p' poetry.lock | sed -n -e 's/^python-versions\s*=\s*//p' | tr -d \" \')" A PR with a test would be appreciated. |
Since we are at it, maybe you could have a look @felix11h ? |
Sure thing, I will have a look! I'm hoping to get to it next week. |
marns93
added a commit
that referenced
this issue
Feb 15, 2023
marns93
added a commit
that referenced
this issue
Feb 15, 2023
marns93
added a commit
that referenced
this issue
Feb 15, 2023
marns93
added a commit
that referenced
this issue
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello! It appears that Python version extraction is currently breaking if the
python-versions = "x.x.x"
line inpoetry.lock
includes a trailing space. This trailing space will be added if the Python version specification inpyproject.toml
also includes a trailing space. I found this because the VSCode TOML plugin I am using adds these spaces: oovm/vscode-toml#7.When that happens, the Heroku build fails with the following message:
To make this more robust, I propose that we strip out spaces in this command:
python-poetry-buildpack/bin/compile
Line 85 in 868d88b
The text was updated successfully, but these errors were encountered: