Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/update default poetry version #59

Merged
merged 3 commits into from
Feb 17, 2023

Conversation

marns93
Copy link
Contributor

@marns93 marns93 commented Feb 15, 2023

@marns93 marns93 requested review from zyv and felix11h February 15, 2023 15:00
Copy link
Contributor

@zyv zyv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you! 👍

Copy link
Contributor

@felix11h felix11h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for preparing this, @marns93!

The section that I was still worried about,

if [ "${POETRY_VERSION:0:3}" = "1.2" ] ; then
    # Allow `poetry export` to work even if we aren't using the
    # Python version that the project will ultimately run in
    log "Force usage of active Python and disable creation of virtualenvs"
    poetry config virtualenvs.prefer-active-python true | indent
    poetry config virtualenvs.create false | indent
fi

seems to be resolved with python-poetry/poetry#6282. We should keep this block for anybody still using Poetry 1.2. Strictly speaking, we probably only need this for the exact Poetry version 1.2.0, but since we're moving on to Poetry ^1.3, and we have received no feedback on this creating problems otherwise, I think we can just leave it as is.

Maybe we can update the comment, however, that this was only required for version 1.2.0 and has been fixed since?

@marns93 marns93 force-pushed the feature/update-default-poetry-version branch from 59e231a to d898232 Compare February 16, 2023 13:12
@marns93
Copy link
Contributor Author

marns93 commented Feb 16, 2023

Thanks for preparing this, @marns93!

The section that I was still worried about,

if [ "${POETRY_VERSION:0:3}" = "1.2" ] ; then
    # Allow `poetry export` to work even if we aren't using the
    # Python version that the project will ultimately run in
    log "Force usage of active Python and disable creation of virtualenvs"
    poetry config virtualenvs.prefer-active-python true | indent
    poetry config virtualenvs.create false | indent
fi

seems to be resolved with python-poetry/poetry#6282. We should keep this block for anybody still using Poetry 1.2. Strictly speaking, we probably only need this for the exact Poetry version 1.2.0, but since we're moving on to Poetry ^1.3, and we have received no feedback on this creating problems otherwise, I think we can just leave it as is.

Maybe we can update the comment, however, that this was only required for version 1.2.0 and has been fixed since?

@felix11h Sure, updated the comment.

@marns93 marns93 merged commit 502c562 into master Feb 17, 2023
@marns93 marns93 deleted the feature/update-default-poetry-version branch February 17, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Python version extraction breaks if a trailing space exists
3 participants