-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/update default poetry version #59
Conversation
marns93
commented
Feb 15, 2023
- Bumped default GitHub action runtime to ubuntu-22.04
- Updated default Poetry version to 1.3.2 ( lockfile is compatible with 1.2.0)
- Fixes Python version extraction breaks if a trailing space exists #43
- Updated test cases to match latest Poetry version + tests for the fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for preparing this, @marns93!
The section that I was still worried about,
if [ "${POETRY_VERSION:0:3}" = "1.2" ] ; then
# Allow `poetry export` to work even if we aren't using the
# Python version that the project will ultimately run in
log "Force usage of active Python and disable creation of virtualenvs"
poetry config virtualenvs.prefer-active-python true | indent
poetry config virtualenvs.create false | indent
fi
seems to be resolved with python-poetry/poetry#6282. We should keep this block for anybody still using Poetry 1.2. Strictly speaking, we probably only need this for the exact Poetry version 1.2.0, but since we're moving on to Poetry ^1.3, and we have received no feedback on this creating problems otherwise, I think we can just leave it as is.
Maybe we can update the comment, however, that this was only required for version 1.2.0 and has been fixed since?
59e231a
to
d898232
Compare
@felix11h Sure, updated the comment. |