Disallow to create empty tags #6235
Labels
Comments
|
Also, after reloading the page, those empty tags disappear, so it seems that this bug is only in the UI |
particleflux
added a commit
to particleflux/monica
that referenced
this issue
Sep 6, 2022
When on a contact page, and adding tags, after adding the first tag, continuously pressing enter adds "empty" tags to the UI. Seems to be introduced by a fix of QA tool issues in 57b31f6 Before this change `this.search != ''` evaluated to true if search was `null`, with a strict comparison that is no longer the case. The `this.search` is reset to `null` though in some cases. I thought about simply extending the condition to also check for `!== null`, though imho the better solution would be to always reset it to empty string state, as is the default value. That also matches some click handler value, and is generally both the value on "non-changed" and on "changed but empty". fixes monicahq#6235
|
Can reproduce locally, seems to be a regression bug. Fixed in #6314 |
asbiin
pushed a commit
that referenced
this issue
Oct 16, 2022
When on a contact page, and adding tags, after adding the first tag, continuously pressing enter adds "empty" tags to the UI. Seems to be introduced by a fix of QA tool issues in 57b31f6 Before this change `this.search != ''` evaluated to true if search was `null`, with a strict comparison that is no longer the case. The `this.search` is reset to `null` though in some cases. I thought about simply extending the condition to also check for `!== null`, though imho the better solution would be to always reset it to empty string state, as is the default value. That also matches some click handler value, and is generally both the value on "non-changed" and on "changed but empty". fixes #6235
|
Thanks ! |
|
🎉 This issue has been resolved in version 4.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
This issue has been automatically locked since there |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
By going to the following page (the page of one person)
http://localhost:9090/people/h:9qyA7LJYWZ18mVavMj
When adding a tag (for example "a"), if you type enter multiple times, it creates as many empty tags as the number of keypresses.
Here is a screenshot of what it results in :
This bugs seems to happen only after entering one tag that is not an empty string.
The text was updated successfully, but these errors were encountered: