fix: Continuously pressing enter shows empty tags #6314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When on a contact page, and adding tags, after adding the first tag, continuously pressing enter adds "empty" tags to the UI. Seems to be introduced by a fix of QA tool issues in 57b31f6 Before this change `this.search != ''` evaluated to true if search was `null`, with a strict comparison that is no longer the case. The `this.search` is reset to `null` though in some cases. I thought about simply extending the condition to also check for `!== null`, though imho the better solution would be to always reset it to empty string state, as is the default value. That also matches some click handler value, and is generally both the value on "non-changed" and on "changed but empty". fixes monicahq#6235
|
Thank you @particleflux |
|
🎉 This PR is included in version 4.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
This pull request has been automatically locked since there |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When on a contact page, and adding tags, after adding the first tag, continuously pressing enter adds "empty" tags to the UI.
Seems to be introduced by a fix of QA tool issues in 57b31f6
Before this change
this.search != ''evaluated to true if search wasnull, with a strict comparison that is no longer the case. Thethis.searchis reset tonullthough in some cases.I thought about simply extending the condition to also check for
!== null, though imho the better solution would be to always reset it to empty string state, as is the default value. That also matches some click handler value, and is generally both the value on "non-changed" and on "changed but empty".fixes #6235