Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update ignored list of currencies in CurrenciesTableSeeder with all default currencies #2988

Merged
merged 3 commits into from
Oct 25, 2019

Conversation

mohammed90
Copy link

Closes #2833

Checklist

Before submitting the PR

  • Read the CONTRIBUTING document before submitting your PR.
  • If the PR is related to an issue or fix one, don't forget to indicate it.
  • [N/A] Indicate [wip] in the title of the PR it is is not final yet. Remove [wip] when ready. Otherwise the PR will be considered complete and rejected if it's not working.

General checks

  • Make sure that the change you propose is the smallest possible.
  • The name of the PR should follow the conventional commits guideline that the project follows.

Front-end changes

  • [N/A] If you change the UI, make sure to ask repositories administrators first about your changes by pinging @djaiss or @asbiin in this PR.
  • [N/A] Screenshots are included if the PR changes the UI.
  • [N/A] Front-end tests have been written with Cypress.

Backend/models changes

  • [N/A] The API has been updated.
  • [N/A] API's documentation has been added by submitting a pull request in the marketing website repository.
  • [N/A] Tests have been added for the new code.
  • [N/A] If you change a model, make sure the FakeContentTableSeeder is updated. We need seeders to develop locally and generate fake data.

If the code changes the SQL schema

  • [N/A] Make sure exporting account data as SQL is still working.
  • [N/A] Make sure your changes do not break importing data with vCard and .csv files.
  • [N/A] Make sure account reset and deletion still work.

Other tasks

  • CHANGELOG entry added, if necessary, under UNRELEASED.
  • CONTRIBUTORS entry added, if necessary.
  • If it's relevant and worth mentioning, create a changelog entry for this change. The changelog entry will appear inside the UI for all users to see. To know if your change is worth the creation of a changelog entry, read the documentation.
  • [N/A] Don't forget to ask for a free account on https://monicahq.com as anyone who contributes can request a free account.

@mohammed90
Copy link
Author

The test "Tests\Api\Settings\ApiCurrencyControllerTest::test_currency_get_all" is expecting 157, but the JSON file contains only 153 currencies. I presume the test is wrong? Because all the currencies in the $ignore list are in the file and more.

@mohammed90
Copy link
Author

Any chance this gets reviewed and, hopefully, merged?

@asbiin
Copy link
Member

asbiin commented Sep 19, 2019

Any chance this gets reviewed and, hopefully, merged?

This will be reviewed in time, after the release 2.15.0 is done.

@asbiin asbiin merged commit 622cb20 into monicahq:master Oct 25, 2019
@asbiin
Copy link
Member

asbiin commented Oct 25, 2019

Thank you @mohammed90 !

@mohammed90 mohammed90 deleted the fix-currency-seed branch October 25, 2019 20:04
@github-actions
Copy link

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Currencies Seeder Ignore List Is Incomplete
2 participants