Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update ignored list of currencies in CurrenciesTableSeeder with all default currencies #2988

Merged
merged 3 commits into from
Oct 25, 2019
Merged

fix: update ignored list of currencies in CurrenciesTableSeeder with all default currencies #2988

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
02cf5af
fix: update ignored list of currencies in CurrenciesTableSeeder with …
mohammed90 Sep 7, 2019
e27fb1b
Merge branch 'master' into fix-currency-seed
asbiin Oct 25, 2019
ccbf5cc
Update CHANGELOG.md
asbiin Oct 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@

### Fixes:

* Fix currencies seeder by accounting for defaults
* Fix search when prefix table is used
* Fix storage page not being displayed if a contact does not exist anymore

Expand Down
1 change: 1 addition & 0 deletions CONTRIBUTORS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,3 +42,4 @@ Stuart Johnston @mechanarchy
Bryan Kam @lydgate
Tom Granot-Scalosub @tomgs
Chris Forrence @chrisforrence
Mohammed Al-Sahaf @Mohammed90
2 changes: 1 addition & 1 deletion database/seeds/CurrenciesTableSeeder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ class CurrenciesTableSeeder extends Seeder
*
* @var string[]
*/
private $ignore = ['CAD', 'USD', 'GBP', 'EUR', 'RUB', 'ZAR'];
private $ignore = ['CAD', 'USD', 'GBP', 'EUR', 'RUB', 'ZAR', 'DKK', 'INR', 'BRL', 'CHF'];

/**
* Runs the seeder.
Expand Down
2 changes: 1 addition & 1 deletion tests/Api/Settings/ApiCurrencyControllerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public function test_currency_get_all()
);

$response->assertJsonFragment([
'total' => 157,
'total' => 153,
'current_page' => 1,
]);

Expand Down