This repository has been archived by the owner on Oct 4, 2021. It is now read-only.
Enable authentication support in New Project Creation Wizard for AspNetCore projects #9583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrward
reviewed
Jan 22, 2020
...oDevelop.DotNetCore/MonoDevelop.DotNetCore.Templating/DotNetCoreProjectTemplateParameters.cs
Show resolved
Hide resolved
.../MonoDevelop.DotNetCore/MonoDevelop.DotNetCore.Templating/DotNetCoreProjectTemplateWizard.cs
Show resolved
Hide resolved
...oDevelop.DotNetCore/MonoDevelop.DotNetCore.Templating/DotNetCoreProjectTemplateWizardPage.cs
Outdated
Show resolved
Hide resolved
Therzok
reviewed
Jan 22, 2020
...oDevelop.DotNetCore/MonoDevelop.DotNetCore.Templating/DotNetCoreProjectTemplateParameters.cs
Outdated
Show resolved
Hide resolved
Therzok
reviewed
Jan 22, 2020
...oDevelop.DotNetCore/MonoDevelop.DotNetCore.Templating/DotNetCoreProjectTemplateParameters.cs
Outdated
Show resolved
Hide resolved
Therzok
reviewed
Jan 22, 2020
...oDevelop.DotNetCore/MonoDevelop.DotNetCore.Templating/DotNetCoreProjectTemplateParameters.cs
Outdated
Show resolved
Hide resolved
nosami
approved these changes
Jan 22, 2020
|
@iantoalms @rodrmoya : https://microsoft.sharepoint.com/:w:/t/vsformac/EVTNIrVjheRAu4-MXSAnMTABYH5BN56911eMadhvBDSQZw?e=XF1fqC , this include the validation details. |
rodrmoya
reviewed
Jan 23, 2020
| leftBorderEventBox.Name = "leftBorderEventBox"; | ||
| mainHBox.Add (leftBorderEventBox); | ||
|
|
||
| var w1 = (Box.BoxChild)mainHBox [leftBorderEventBox]; |
There was a problem hiding this comment.
Instead of doing this, better to just call mainHBox.PackStart (or PackEnd) which has optional parameters for all Expand
rodrmoya
reviewed
Jan 23, 2020
| configurationTopEventBox.Name = "configurationTopEventBox"; | ||
| configurationVBox.Add (configurationTopEventBox); | ||
|
|
||
| var w2 = (Box.BoxChild)configurationVBox [configurationTopEventBox]; |
There was a problem hiding this comment.
ditto here, just use PackStart instead of .Add and all this code
rodrmoya
reviewed
Jan 23, 2020
| configurationTableEventBox.Add (configurationTable); | ||
| configurationVBox.Add (configurationTableEventBox); | ||
|
|
||
| var w7 = (Box.BoxChild)configurationVBox [configurationTableEventBox]; |
rodrmoya
reviewed
Jan 23, 2020
| targetFrameworkComboBox.Name = "targetFrameworkComboBox"; | ||
| configurationTable.Add (targetFrameworkComboBox); | ||
|
|
||
| var w3 = (Table.TableChild)configurationTable [targetFrameworkComboBox]; |
There was a problem hiding this comment.
and for Table's, just use Attach instead of Add, which has optional parameters for all the properties being set below
…templates which support it
- Fix up formatting - Move from IList to IReadOnlyList where appropriate
Fix issue with Web API template where NoAuth is only supported option
iantoalms
force-pushed
the
iantoal/pr-Enable-Auth-For-AspDotNetCore
branch
from
e6e1057 to
44fce79
Compare
rodrmoya
approved these changes
Jan 23, 2020
mrward
approved these changes
Jan 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1035347
Fixes: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/820015
Fixes: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/669931
Fixes: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/669926
Fixes: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/669911
User Stories:
Feature details:
Added support to detect if an AspDotNet Core project template has support for authentication options. We currently only support the Individual auth (local in-app) option. The user is presented with the option of configuring authentication during project creation (See screenshot below)
Screenshot:
Testing: