-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port Step tracing perf + more shared code #20
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port moonbeam-foundation/moonbeam#1033 to the tracing runtime overrides.
Since
evm-tracing-events
now have a Substrate dependency, I had to think again about how to support code sharing across runtime versions. After some tests I finally found a trick that seems to work.In the shared crates I set the git path of substrate and frontier to a fork of substrate and a dummy branch (at some commit using Rust 2018 edition so it works even for our oldest runtimes). I have to use a separate repo due to this bug in cargo : rust-lang/cargo#5478
Then in the main .toml of each runtime version, I patch the dependencies to set the correct revision of substrate and frontier. Thus the forks are only there to check the crate existence, and then the correct version is used. Currently I forked in my personal namespace, but we should have the forks under the PureStake namespace (due to the bug above sadly it can't be the repos we already used).
Finally there is a change in ethereum types between versions. A feature flag is thus used to select the correct version to use.
TODO
common
crate, as the rest should either be fetched from the main repo or use the patched shared version.