Improve performance of EVM tracing Step event #1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanocryk
added
A3-inprogress
3 tasks
nanocryk
force-pushed
the
jeremy-evm-tracing-step-perf
branch
from
9b36b68 to
5a5d448
Compare
tgmichel
approved these changes
Dec 16, 2021
tgmichel
added
A8-mergeoncegreen
|
Lets wait until moonbeam-foundation/moonbeam-runtime-overrides#20 is ready to be merged too. |
crystalin
added
the
B5-clientnoteworthy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
When emitting a Step event the EVM include the content of the stack and memory, which have a huge performance cost in transactions with a lot of steps. This PR aims to allow choosing if the stack/memory must be kept (cloned) or discarded.
It seems to perform similarely to current "fix" which disabled emitting the Step event in the EVM with a feature flag. This PR thus allow the client to control which data should be cloned, and allow raw tracing to work again without needing to build custom tracing images.
What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?