Magnum Player #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6 +/- ##
=======================================
Coverage 18.68% 18.68%
=======================================
Files 35 35
Lines 1450 1450
=======================================
Hits 271 271
Misses 1179 1179Continue to review full report at Codecov.
|
45 tasks
Squareys
reviewed
Aug 8, 2018
src/player/player.html
Outdated
| </head> | ||
| <body> | ||
| <h1>Magnum glTF Player</h1> | ||
| <p style="max-width: 640px; text-align: center; margin-left: auto; margin-right: auto;">Drag & drop your <tt>*.glb</tt> (or an <em>embedded</em> <tt>*.gltf</tt>) file into the grey rectange below to play it. Refresh the browser if it gets stuck. I'm not responsible for anything :P</p> |
There was a problem hiding this comment.
"rectange" should be "rectangle" 😉
mosra
force-pushed
the
player
branch
2 times, most recently
from
636eacc to
6000b10
Compare
mosra
force-pushed
the
player
branch
4 times, most recently
from
ea95753 to
f0c755a
Compare
mosra
force-pushed
the
player
branch
3 times, most recently
from
b175dba to
b1f561c
Compare
Looks like static build on Windows was never working properly.
Initial code is a plain copy of the Viewer example.
And if possible, import the initial TRS properties separately. Makes it better for handling animations.
Better than crashing during an animation.
For drag & drop.
The file will be specified through drag&drop, so this is not doing anything at the moment.
It needs Ui, which doesn't work on WebGL 1 / ES2.
Well, basically it's recreating it from scratch. Sorry, ugly, verbose and slow. Needs to be done properly later.
Reused from the Mouse Interaction example.
Again just a copy from the Mouse Interaction example.
But only 2x on HiDPI and allow the users to override that.
Apparently hierarchy is not preserved with browser D&D so if a file in subdir is not found, we try again using just the filename.
Otherwise the animation time might not get displayed when the destination random value would be matching animation progress.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will become an extended version of the Viewer example with the end goal being an ability to view and play any 3D file you throw at it.
The initial goals, in scope of this PR, are:
doc/utilities.doxAbility to specify aspect ratio of the viewAbility to full-size the viewScreenshot savingpostponedSome default scene for the web view (animated cube at least)postponedFigure out the depth issuespostponedSome better scene info (a modal) .. also cam count etc.postponed