-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JpegImageConverter plugin, JPEG support in StbImageConverter #26
Conversation
4a6a8bb
to
98a1395
Compare
Revived this PR now, hopefully on track for 2018.08. Turns out the original code was not taking pixel storage properties correctly into account, which explains the huge perceived difference in output. Now testing both with "ground truth" data and using DebugTools::CompareImage to ensure reasonable error margin when the output is with 100% quality setting. After The main blocker now is an ability to find DebugTools without requiring all optional dependencies it has so the CI doesn't need to spend time building things that are not needed. |
98a1395
to
bac1eb8
Compare
In order to unblock the progress, I merged the majority of the additions into master (e2c4ae2...b40ef6f). The only remaining bit is the additional check using DebugTools::CompareImage, blocked by the above. |
Codecov Report
@@ Coverage Diff @@
## master #26 +/- ##
=======================================
Coverage 89.12% 89.12%
=======================================
Files 43 43
Lines 4265 4265
=======================================
Hits 3801 3801
Misses 464 464
Continue to review full report at Codecov.
|
07fe612
to
b8466fc
Compare
…put. Uses DebugTools::CompareImage to verify the converted output is not too far from the input.
b8466fc
to
228e2d4
Compare
A new plugin creating JPEGs out of your 8-bit RGB and grayscale image data. The test is failing on small input (while I'm pretty sure it works on larger input), needs further investigation.
Opening a PR in case someone finds this code handy (and also so it doesn't get lost in my abandoned branches).
TODO:
AbstractImageConverter
(note to self: there's ajpeg
branch of magnum for this) mosra/magnum@c60217a