Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set working ros index for rolling #702

Merged
merged 3 commits into from
May 9, 2022
Merged

Conversation

cgarry-vs
Copy link
Contributor

moveit/moveit2#1120

Description

This fixes issue moveit/moveit2#1120

Checklist

  • Tested modified webpage locally using the build_locally.sh script
  • While waiting for someone to review your request, please consider reviewing another open pull request to support the maintainers

@welcome
Copy link

welcome bot commented Mar 23, 2022

Thanks for helping in improving MoveIt and open source robotics!

Copy link
Contributor

@vatanaksoytezer vatanaksoytezer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR @cgarry-vs . There needs some clarification on the situation with Galactic, Rolling Focal and Rolling Jammy. I'd be happy to review again and merge once the issues below are addressed.

@cgarry-vs
Copy link
Contributor Author

Addressed comments.

@cgarry-vs
Copy link
Contributor Author

Ping.

Copy link
Contributor

@vatanaksoytezer vatanaksoytezer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you @cgarry-vs!

Copy link
Member

@JafarAbdi JafarAbdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the Rolling on Ubuntu Focal (Deprecated) section, main only support the latest rolling version (which is already incompatible with the last version released for focal)

@JafarAbdi JafarAbdi merged commit 28d36d5 into moveit:main May 9, 2022
@welcome
Copy link

welcome bot commented May 9, 2022

Congrats on getting your first MoveIt pull request merged and improving open source robotics!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants