-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set working ros index for rolling #702
Conversation
Thanks for helping in improving MoveIt and open source robotics! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the PR @cgarry-vs . There needs some clarification on the situation with Galactic, Rolling Focal and Rolling Jammy. I'd be happy to review again and merge once the issues below are addressed.
Addressed comments. |
Ping. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you @cgarry-vs!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the Rolling on Ubuntu Focal (Deprecated)
section, main only support the latest rolling version (which is already incompatible with the last version released for focal)
Congrats on getting your first MoveIt pull request merged and improving open source robotics! |
moveit/moveit2#1120
Description
This fixes issue moveit/moveit2#1120
Checklist
build_locally.sh
script