Update default planning configs to use AddTimeOptimalParameterization #2167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JafarAbdi
reviewed
May 10, 2023
moveit_ros/planning/planning_request_adapters_plugin_description.xml
Outdated
Show resolved
Hide resolved
JafarAbdi
approved these changes
May 10, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #2167 +/- ##
==========================================
+ Coverage 50.48% 50.49% +0.01%
==========================================
Files 387 387
Lines 31785 31785
==========================================
+ Hits 16044 16047 +3
+ Misses 15741 15738 -3 ☔ View full report in Codecov by Sentry. |
MarqRazz
approved these changes
May 10, 2023
|
@Mergifyio backport humble |
❌ Command disallowed due to command restrictions in the Mergify configuration.
|
|
@JafarAbdi I don't have permissions to backport, would you mind doing it? |
JafarAbdi
added
the
backport-humble
JafarAbdi
pushed a commit
that referenced
this pull request
May 10, 2023
…#2167) (#2170) (cherry picked from commit 895e926) Co-authored-by: Anthony Baker <[email protected]>
sjahr
pushed a commit
to PickNikRobotics/moveit2
that referenced
this pull request
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've updated the default planning configs found in the
MoveIt_Config_Utilspackage to useAddTimeOptimalParameterizationinstead ofAddTimeParameterizationbecause the latter was deleted in this PR.I happen to stumble upon this issue after generating a MoveIt 2 config using the Setup Assistant and trying to execute a successful plan with the default config.
Checklist