Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update default planning configs to use AddTimeOptimalParameterization #838

Closed
wants to merge 1 commit into from
Closed

Update default planning configs to use AddTimeOptimalParameterization #838

wants to merge 1 commit into from

Conversation

skpawar1305
Copy link
Contributor

referring moveit/moveit2#2167

Description
AddTimeOptimalParameterization instead of AddTimeParameterization because the latter was deleted in this PR.

Affected Packages
List of affected packages:

  • webots_ros2_universal_robot

ygoumaz
ygoumaz requested changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@ygoumaz ygoumaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! An entry should be added for version 2023.1.2 in the main changelog and in the one for webots_ros2_universal_robot (CHANGELOG.rst files).

@skpawar1305 skpawar1305 mentioned this pull request Jul 26, 2023
Merged
@ygoumaz
Copy link
Contributor

ygoumaz commented Jul 27, 2023

Closing this PR, as the fix is duplicated in #837.

@ygoumaz ygoumaz closed this Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ygoumaz ygoumaz ygoumaz requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skpawar1305 @ygoumaz