MPP-3818: Append missing strings in English #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
groovecoder
approved these changes
May 23, 2024
peiying2
approved these changes
May 23, 2024
There was a problem hiding this comment.
@groovecoder I approve the PR. From the conversation in the Slack channel, it sounds like Flod has a way to look into recovering the localized strings. Are you planning on going ahead without checking in on that possibility?
groovecoder
approved these changes
May 23, 2024
|
Why was this merged? I explicitly called out that we needed time to try and recover previous translations. Now we have added 32 "brand-new" strings to the project, and it's potentially too late to do anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding back missing strings from the Relay landing page, /premium, and premium onboarding step #1.
Currently added the English ones so we can get them into production.
Will create another PR to recover other languages.