Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Alias to Mask announcement strings #72

Merged
merged 4 commits into from
Apr 19, 2022
Merged

Conversation

codemist
Copy link
Collaborator

@codemist codemist commented Apr 7, 2022

image

@codemist codemist requested a review from peiying2 as a code owner April 7, 2022 16:52
@Vinnl
Copy link
Collaborator

Vinnl commented Apr 11, 2022

I added 9860974 to this so we can fix this: mozilla/fx-private-relay#1738 (comment), hope you don't mind. It's an alt text for the "This link opens in a new tab" icon:

image

Other strings look good to me.

@Vinnl
Copy link
Collaborator

Vinnl commented Apr 12, 2022

(Small heads-up that I shortened the alt text I added as per an a11y recommendation, to make screen readers less verbose: b2f1f9f.)

Edit: and also a3bd0cc to add parentheses, as OK'd by a11y. (Note that I'm only adding these because it wasn't merged yet, otherwise it'd have been fine as-is.)

Copy link
Contributor

@peiying2 peiying2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I will let you merge whenever you are ready or wait for more strings to consolidate on the PRs.

@Vinnl Vinnl merged commit 66044ac into main Apr 19, 2022
@Vinnl Vinnl deleted the whats-new-alias-to-mask branch April 19, 2022 14:55
@flodolo
Copy link
Contributor

flodolo commented Apr 19, 2022

What about locales who didn't change the translation from alias to mask? There's no way to work around this…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants