Add alt text for the "New tab" icon #1775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that this alt text is likely to be the same everywhere, so I just added it to the icon directly (but allowing for it to be overwritten at the point of use, if necessary).
maxxcrawford
approved these changes
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was initially to be added in #1738 (comment), but that got merged already.
Note that this alt text is likely to be the same everywhere, so I
just added it to the icon directly (but allowing for it to be
overwritten at the point of use, if necessary).
How to test: Verify that there is now an alt text everywhere the "This link opens in a new tab" icon shows up (in the user menu, and the menu items on the left-hand side of the settings page on desktop).
/static/scss/libs/protocol/css/includes/tokens/dist/index.scss).