Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fix] Added support for compound octet string #64

Conversation

nisargap
Copy link

@nisargap nisargap commented Oct 15, 2021

Compound octet strings currently are not covered by the PKCS7 parsing function. For cases such as Apple Attest Validation or MS Crypto API this library can't be used until this is fixed.

See the original PR Patch (it was never merged in) : fullsailor#36

@nisargap
Copy link
Author

cc for approval @g-k

@g-k g-k self-requested a review October 15, 2021 16:57
Copy link

@g-k g-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! This seems reasonable.

Can you add some tests with fixtures from the Apple Attest Validation or MS Crypto API that exercises the new code? They can go in https://github.com/mozilla-services/pkcs7/blob/master/verify_test.go

@nisargap nisargap requested a review from g-k October 16, 2021 00:45
@nisargap
Copy link
Author

@g-k Just added a test with a sample apple attestation receipt fixture, with the new changes the full compound octet string content is able to be parsed by the parseSignedData function, with the old code it truncates the content

@nisargap
Copy link
Author

cc: @g-k

@nisargap
Copy link
Author

cc: @g-k can someone with write access merge? i've been maintaining my own fork for several weeks now, thank you!

@g-k
Copy link

g-k commented Apr 19, 2022

I don't worked at Mozilla anymore, so I can't land any PRs.

Can't promise anything, but maybe @ajvb can take a look.

@nisargap
Copy link
Author

cc for approval @ajvb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARCHIVED CLOSED at time of archiving
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants