Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use github.com/smallstep/pkcs7 fork with (selected) patches applied #932

Merged
merged 1 commit into from
May 18, 2022

Conversation

hslatman
Copy link
Member

@hslatman hslatman commented May 11, 2022

Name of feature:

Use https://github.com/smallstep/pkcs7 fork with (selected) patches applied.

The patches are applied to the patches branch. As of now, only the commits from mozilla-services/pkcs7#64 have been applied.

Pain or issue this feature alleviates:

Problems with large SCEP requests failing to be processed correctly.

More generally, this allows us to apply more patches if necessary, since maintenance on github.com/mozilla-services/pkcs7 seems to have stalled (for now).

Supporting links/other PRs/issues: #908

@github-actions github-actions bot added the needs triage Waiting for discussion / prioritization by team label May 11, 2022
@hslatman hslatman requested a review from maraino May 17, 2022 21:54
Copy link
Contributor

@maraino maraino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hslatman hslatman merged commit 984e4fc into master May 18, 2022
@hslatman hslatman deleted the herman/pkcs7-patches branch May 18, 2022 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Waiting for discussion / prioritization by team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants