Skip to content

Commit

Permalink
Merge pull request #5166 from mozilla/sass-1-80-updates-mpp-3946
Browse files Browse the repository at this point in the history
MPP-3946: Silence deprecration warnings added in sass 1.80, fix division
  • Loading branch information
groovecoder authored Nov 1, 2024
2 parents 05d4402 + ce50ae4 commit b96932c
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 1 deletion.
14 changes: 14 additions & 0 deletions frontend/next.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -114,4 +114,18 @@ module.exports = {

return config;
},
sassOptions: {
// TODO MPP-3946: Fix deprecation warnings in sass 1.80.x
// https://github.com/mozilla/protocol/releases/tag/v18.0.0
silenceDeprecations: [
// Issues we can fix in our code
"import", // https://sass-lang.com/documentation/breaking-changes/import/
"mixed-decls", // https://sass-lang.com/d/mixed-decls

// Upstream issues
"legacy-js-api", // vercel/next.js issue #71638
],
// TODO MPP-3946: Update to mozilla-protocol 18.0.0
quietDeps: true,
},
};
2 changes: 1 addition & 1 deletion frontend/src/components/landing/PlanMatrix.module.scss
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ table.desktop {
// border-collapse: separate;
// border-spacing: $spacing-md 0;
// then we wouldn't have been able to apply a bottom border at all.
border-inline: $spacing-md / 2 solid $color-light-gray-10;
border-inline: $spacing-md * 0.5 solid $color-light-gray-10;

&:last-child {
border-right-style: none;
Expand Down

0 comments on commit b96932c

Please sign in to comment.