MPP-3946: Silence deprecration warnings added in sass 1.80, fix division #5166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dart Sass 1.80.0 added deprecation warnings for several features used by Relay and mozilla-protocol v17. This silences the warnings so that other build issues will not be lost in the noise.
Use migrator to replace division with multiplication: npx sass-migrator division **/*.scss No change in the generated .css file.
groovecoder
approved these changes
Nov 1, 2024
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR configures Dart Sass to silence deprecation warnings that appear after the upgrade to sass 1.80.x. This will prevent other errors and warnings from getting lost in the noise as we incrementally fix the issues.
This PR does fix the easiest issue, the deprecation of slash as division. The automated fix was applied with:
How to test:
This can be confirmed in local dev or by looking at the CI build for this PR:
cd frontend; npm run buildfrontend/out/_next/static/css/7b7332110014f2b1.cssstill exists, since the contents did not change and the filename is based on a hash of the contents. The file7b7332110014f2b1.css.mapis different, since the source changed.