Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change message banner to non-alert color #829

Closed
2 tasks
say-yawn opened this issue May 11, 2021 · 1 comment · Fixed by #831
Closed
2 tasks

Change message banner to non-alert color #829

say-yawn opened this issue May 11, 2021 · 1 comment · Fixed by #831
Assignees
@maxxcrawford
Labels
🐛 bug Something isn't working 🕸 website

Comments

@say-yawn
Copy link
Contributor

About this Issue

After #827, while the errors are being displayed properly, non-errors are being displayed like errors (successful login/logout). We should change the banner color such that the non-errors and errors alike can be displayed to the users.
Screen Shot 2021-05-11 at 10 38 47

Acceptance Criteria

  • Errors are displayed properly
  • Messages are displayed properly (are not displayed like they may be errors)
@groovecoder groovecoder added 🐛 bug Something isn't working 🕸 website labels May 11, 2021
maxxcrawford added a commit that referenced this issue May 11, 2021
@maxxcrawford
Fix #829 - Refactor CSS default message color
2e48668
@maxxcrawford maxxcrawford linked a pull request May 11, 2021 that will close this issue
Fix #829 - Refactor CSS default message color #831
Merged
groovecoder added a commit that referenced this issue May 12, 2021
@groovecoder
Merge pull request #831 from mozilla/829-fix-message-color
c0b4d3c 
Fix #829 - Refactor CSS default message color
@groovecoder
Copy link
Member

Should we consider #126 fixed with this too?

@groovecoder groovecoder mentioned this issue Jun 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxxcrawford maxxcrawford

Labels
🐛 bug Something isn't working 🕸 website
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #829 - Refactor CSS default message color mozilla/fx-private-relay
3 participants
@groovecoder @maxxcrawford @say-yawn