Handle errors properly on Emails #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
say-yawn
commented
May 4, 2021
| @@ -262,7 +267,7 @@ def make_domain_address(user_profile, address=None, made_via_email=False): | |||
| ) | |||
|
|
|||
| address_contains_badword = False | |||
| if address is None: | |||
| if not address: | |||
There was a problem hiding this comment.
Doing not address because address value can be an empty string which would fail this check.
|
Merge now. Fix later. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this PR
Fast follow to fix some dev tested errors on #808. Some fixes include: