Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The alias where the messages are forwarded is not displayed in the Delete alias modal text #862

Closed
Bianca-O opened this issue Jun 11, 2021 · 4 comments · Fixed by #883
Closed

The alias where the messages are forwarded is not displayed in the Delete alias modal text #862

Bianca-O opened this issue Jun 11, 2021 · 4 comments · Fixed by #883
Assignees
@maxxcrawford @codemist
Labels
priority-P1 softvision Issue filed from Softvision QA team

Comments

@Bianca-O
Copy link
Collaborator

Bianca-O commented Jun 11, 2021 •
edited
Loading

Build:
Dev

Affected platforms:
Windows 10 64-bit
macOS 10.15

Browsers tested on:
Firefox

Preconditions:
The user is logged in to Firefox Relay.
The user has already added some aliases.

Steps to reproduce:

  1. Select an alias and click the “Show Details” option.
  2. Click “Delete” button.
  3. Observe the text displayed in the modal.

Actual result:
The alias where the messages are forwarded is missing from the text.

Expected result:
The alias where the messages are forwarded is displayed in the text.

alias missing
@maxxcrawford maxxcrawford added the softvision Issue filed from Softvision QA team label Jun 14, 2021
@maxxcrawford
Copy link
Contributor

May be related to #863

@maxxcrawford maxxcrawford self-assigned this Jun 14, 2021
maxxcrawford added a commit that referenced this issue Jun 15, 2021
@maxxcrawford
Fix #862 - Add email address to delete dialog
6d42eeb
@maxxcrawford maxxcrawford linked a pull request Jun 15, 2021 that will close this issue
Softvision QA Fixes - Front-end #883
Merged
@maxxcrawford maxxcrawford mentioned this issue Jun 15, 2021
Merged
maxxcrawford added a commit that referenced this issue Jun 16, 2021
@maxxcrawford
Fix #862 - Add email address to delete dialog
ce7e0e1
@Bianca-O
Copy link
Collaborator Author

Bianca-O commented Jun 22, 2021 •
edited
Loading

@maxxcrawford @groovecoder Verified this issue on Stage under Windows 10 64-bit and macOS. The real email address is displayed in the Delete dialog and I just wanted to check if that is correct. Shouldn't the alias be displayed instead? See figma.

figma MPP

@groovecoder
Copy link
Member

Thanks for the catch. Re-opening.

@groovecoder groovecoder reopened this Jun 22, 2021
@codemist codemist mentioned this issue Jul 7, 2021
Merged
codemist added a commit that referenced this issue Jul 7, 2021
@codemist
Fix #862 - Change user email to alias email in modal popup (Error: Mo…
72b804c 
…dal does not open)
codemist added a commit that referenced this issue Jul 8, 2021
@codemist
Fix #862 - Change user email to alias email in delete warning modal m…
d82224d 
…essage
codemist added a commit that referenced this issue Jul 8, 2021
@codemist
Fix #862 - Removed extra spaces in app.ftl file
25162d8
maxxcrawford added a commit that referenced this issue Jul 9, 2021
@maxxcrawford
Merge pull request #905 from mozilla/display-alias
e445eb1 
Fix #862 - Changed user email to alias email in modal message
@Bianca-O
Copy link
Collaborator Author

Verified this issue on Stage under Windows 10 64-bit and macOS. I confirm that the alias is displayed in the Delete dialog.

new situation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxxcrawford maxxcrawford

@codemist codemist

Labels
priority-P1 softvision Issue filed from Softvision QA team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Softvision QA Fixes - Front-end mozilla/fx-private-relay
4 participants
@groovecoder @maxxcrawford @codemist @Bianca-O