Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Softvision QA Fixes - Front-end #883

Merged
merged 4 commits into from
Jun 17, 2021
Merged

Softvision QA Fixes - Front-end #883

merged 4 commits into from
Jun 17, 2021

Conversation

maxxcrawford
Copy link
Contributor

@maxxcrawford maxxcrawford commented Jun 15, 2021

Summary

This PR addresses multiple issues filed by QA

Testing

Add email address to delete dialog (#862)

  • Log into Relay
  • Create an alias (if there are none)
  • Expand that alias
  • Click "Delete"
  • **Expected: The modal should include the forwarding email address within the copy **

Hide banner block when invisible (#868)

  • Log into Relay
  • Install the add-on (use stage build)
  • Upgrade account
  • Select subdomain
  • Expected: There should be no more notifications. There should be no empty whitespace between top of page and the list of aliases. (See screenshot below)

Update z-index issue on hover (#870)

  • Log into Relay
  • Create at least two aliases (if there are none)
  • Hover over the "Forwarded" label on the first alias.
  • Expected: The tooltip should not be obscure.

Remove subdomain banner, move to dashboard header (#863)

  • Log into Relay
  • Install the add-on (use stage build)
  • Upgrade account
  • Select subdomain
  • Expected: The subdomain you selected should now be in the dashboard header underneath the welcome message

Screenshots

Add email address to delete dialog (#862)

image

Hide banner block when invisible (#868)

image

Update z-index issue on hover (#870)

image

Remove subdomain banner, move to dashboard header (#863)

image

@maxxcrawford maxxcrawford marked this pull request as ready for review June 16, 2021 19:30
@groovecoder
Copy link
Member

Looks good - nice fixes!

@groovecoder groovecoder merged commit 9c50585 into main Jun 17, 2021
@groovecoder groovecoder deleted the front-qa-fixes branch June 17, 2021 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants