Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Waitlist CTA for users in non-premium countries #2106

Merged
merged 18 commits into from
Jun 27, 2022
Merged

Waitlist CTA for users in non-premium countries #2106

merged 18 commits into from
Jun 27, 2022

Conversation

codemist
Copy link
Collaborator

@codemist codemist commented Jun 21, 2022

New feature description

When a user is from a non-premium country, the pricing panels on the landing page will show different UI: a premium waitlist CTA and encourage them to sign up for a free account in the meantime.

Note: Some minor discrepancies between the design spec and the UI, but confirmed with Eduardo that they're a non-issue.

Screenshot (if applicable)

Desktop view:
image

Mobile view:
image

How to test

  1. Go to the landing page and check that the original pricing plans section has not changed.

  2. Change your browser language to a non-premium country such as Romanian (Română) and check that the pricing section displays the updated UI as shown above.

Checklist

  • l10n dependencies have been merged, if any.
  • All acceptance criteria are met.
  • I've added or updated relevant docs in the docs/ directory.
  • All UI revisions follow the coding standards, and use Protocol tokens where applicable (see /static/scss/libs/protocol/css/includes/tokens/dist/index.scss).
  • Commits in this PR are minimal and have descriptive commit messages.

@codemist codemist marked this pull request as ready for review June 23, 2022 16:10
@codemist codemist requested a review from Vinnl June 23, 2022 16:22
Copy link
Collaborator

@Vinnl Vinnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking pretty good! There's just a small broken layout that needs fixing, and I provided a couple of suggestions to help with positioning without relying on magic numbers.

margin-top: -40px;
width: 180px;
height: 30px;
background-image: url("../../../../static/images/newlanding/ribbon-plan.svg");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately we haven't been able to merge #1998 yet, so you couldn't deduce this from looking at other background-images, but... We only used the static directory for backwards compatibility while migrating to React.

Now that we've migrated, you can put images next to where they are used, so you don't need to move up all those directories, which is a pattern Maxx and Luke asked us to use. See e.g. https://github.com/mozilla/fx-private-relay/pull/1998/files#diff-8291c47a2bca23664c27f5f184c26351f367bbba1f83f05b528cd7be53ffc09eR41

frontend/src/components/landing/Plans.module.scss Outdated Show resolved Hide resolved
@include text-body-xs;
position: absolute;
color: white;
font-weight: 700;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we were using 500? :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, guess I have to take my own review medicine lol

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I checked the Figma spec and it does set to 700. Perhaps we should store font weights into a variable like font-weight-bold or font-weight-extra-bold so its standard across the board?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, not sure - the Figma said 700 in my PR where you called that out as well, then when I asked Eduardo, he changed it to 500. So I don't have a strong preference here, but if Eduardo indeed wants another level of boldness, those variables would make sense to me.

frontend/src/components/landing/Plans.module.scss Outdated Show resolved Hide resolved
frontend/src/pages/index.page.tsx Outdated Show resolved Hide resolved
frontend/src/pages/index.module.scss Show resolved Hide resolved
frontend/src/components/landing/Plans.tsx Outdated Show resolved Hide resolved
frontend/src/components/landing/Plans.tsx Outdated Show resolved Hide resolved
frontend/src/components/landing/Plans.tsx Show resolved Hide resolved
@codemist codemist requested a review from Vinnl June 24, 2022 16:07
Copy link
Collaborator

@Vinnl Vinnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

frontend/src/components/landing/Plans.module.scss Outdated Show resolved Hide resolved
@include text-body-xs;
position: absolute;
color: white;
font-weight: 700;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, not sure - the Figma said 700 in my PR where you called that out as well, then when I asked Eduardo, he changed it to 500. So I don't have a strong preference here, but if Eduardo indeed wants another level of boldness, those variables would make sense to me.

@codemist codemist merged commit e3650ca into main Jun 27, 2022
@codemist codemist deleted the waitlist-cta branch June 27, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants