Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Waitlist CTA in Pricing Plans for Interstitial Page #2161

Merged
merged 2 commits into from
Jul 6, 2022

Conversation

codemist
Copy link
Collaborator

@codemist codemist commented Jul 5, 2022

This includes a sub feature of #2106, and unblocks MPP-1928

image

  1. Go to the interstitial page and check that the original pricing plans section has not changed.

  2. Change your browser language to a non-premium country such as Romanian (Română) and check that the pricing section displays the updated UI as shown above.

@codemist codemist requested a review from Vinnl July 5, 2022 14:54
Copy link
Collaborator

@Vinnl Vinnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh heh, I hadn't noticed this wasn't added to the interstitial yet :) The only thing that jumped out to me is that #2106 also included changes to index.module.scss, whereas this one doesn't have any changes to premium.module.scss. I don't see any visual changes, so maybe the former wasn't necessary?

@codemist codemist merged commit fa2b089 into main Jul 6, 2022
@codemist codemist deleted the waitlist-plans-interstitial branch July 6, 2022 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants