MPP-2503: Change Profile.user to OneToOneField #2749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fx-relay-demo canceled.
|
jwhitlock
force-pushed
the
profile-user-one-to-one-2708
branch
2 times, most recently
from
426385d to
a09fd3c
Compare
jwhitlock
force-pushed
the
profile-user-one-to-one-2708
branch
from
a09fd3c to
a100cc2
Compare
jwhitlock
added
Review: S
groovecoder
approved these changes
Nov 9, 2022
| @@ -215,66 +215,3 @@ def markdown_report(self) -> str: | |||
| ) | |||
|
|
|||
| return "\n".join(lines) | |||
|
|
|||
|
|
|||
| class ManyProfileDetector(DetectorTask): | |||
| @@ -217,21 +217,21 @@ def test_sns_message_with_hard_bounce(self): | |||
|
|
|||
| _sns_notification(BOUNCE_SNS_BODIES["hard"]) | |||
|
|
|||
| profile = self.user.profile_set.get() | |||
| assert profile.last_hard_bounce >= pre_request_datetime | |||
| self.user.refresh_from_db() | |||
There was a problem hiding this comment.
question (non-blocking): does refresh_from_db() also refresh related field data? Looks like most of these tests are written such that they might pass even if the data was stale?
There was a problem hiding this comment.
I had to go prove it to myself, but yes it does. This part of the docs wasn't clear to me:
If you need to reload a model’s values from the database, you can use the refresh_from_db() method. When this method is called without arguments the following is done:
- All non-deferred fields of the model are updated to the values currently present in the database.
- Any cached relations are cleared from the reloaded instance.
I had to play around in ./manage.py shell to see how it worked:
>>> from django.contrib.auth.models import User
>>> from emails.models import Profile
>>> user = User.objects.latest("date_joined")
>>> profile = user.profile
>>> user.profile.num_address_deleted
0
>>> profile.num_address_deleted
0
>>> # The two are now distinct objects
>>> user.profile.num_address_deleted = 10
>>> profile.num_address_deleted
0
>>> user.profile.save()
>>> profile.num_address_deleted
0
>>> profile.refresh_from_db()
>>> profile.num_address_deleted
10
>>> # Going the other way...
>>> profile.num_address_deleted = 20
>>> profile.save()
>>> user.profile.num_address_deleted
10
>>> # This clears user.profile from the cached relations
>>> user.refresh_from_db()
>>> # And this loads the profile from the database
>>> user.profile.num_address_deleted
20
Change Profile.user from ForeignKey to OneToOneField. Make follow-on
changes:
* Change user.profile_set.get() to user.profile
* Change prefetch_related_objects('profile_set') to profile
* Remove ManyProfileDetector (no longer possible)
* Drop ./manage.py cleanup_data --many-profiles
groovecoder
force-pushed
the
profile-user-one-to-one-2708
branch
from
a100cc2 to
623bfda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This will fail CircleCI migration tests until
2022.11.02is in productionChange Profile.user from ForeignKey to OneToOneField, to fix issue #2708 / MPP-2503. This requires some follow-on changes:
user.profile_set.get()touser.profileprefetch_related_objects('profile_set')toprefetch_related_objects('profile')ManyProfileDetector(no longer possible)./manage.py cleanup_data --many-profilesAlso makes some changes suggested by
flake8, such as removing unused imports.