MPP-3827 - Prefer user.profile to Profile.objects.get(user=user)
#4798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
jwhitlock
force-pushed
the
user-profile-mpp-4763
branch
from
1fd6d6e to
68eec35
Compare
say-yawn
requested changes
Jun 25, 2024
emails/models.py
Outdated
| @@ -655,7 +655,8 @@ def delete(self, *args, **kwargs): | |||
| num_spam=self.num_spam, | |||
| ) | |||
| deleted_address.save() | |||
| profile = Profile.objects.get(user=self.user) | |||
| profile = self.user.profile | |||
| profile.refresh_from_db() | |||
There was a problem hiding this comment.
(question, non-blocking) Why was the profile.refresh_from_db() needed?
There was a problem hiding this comment.
I removed it, tests were OK, so let's remove it.
A refresh_from_db() would be a good idea if we use F expressions to avoid race conditions here:
https://docs.djangoproject.com/en/4.2/ref/models/expressions/#avoiding-race-conditions-using-f
There was a problem hiding this comment.
Whoa! I didn't know about F expressions. Good to know going forward we can use this especially for incrementing!
Comment on lines
-862
to
+859
| # self.user_profile is a property and should not be used to | ||
| # update values on the user's profile | ||
| profile = Profile.objects.get(user=self.user) | ||
| profile = self.user.profile |
jwhitlock
changed the title
user.profile to Profile.objects.get(user=user)user.profile to Profile.objects.get(user=user)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pattern
profile = Profile.objects.get(user=user)was useful whenuserhad aForiegnKeyrelationship. Since #2749, it has been unnecessary. Switching these touser.profilehas some benefits:user.profileand the stand-aloneProfileobject, which could introduce bugsProfileis no longer needed, which will reduce the code changes when movingProfiletoprivaterelay.