Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e2e tests for Mozilla Account changes #4346

Merged
merged 3 commits into from
Jan 25, 2024
Merged

Conversation

jwhitlock
Copy link
Member

The end-to-end tests have been broken since January 19th, 2024. This may be due to a "Full prod rollout of react signup" on January 18th:

mozilla/fxa@0881a39

This PR fixes the end-to-end tests for me.

Mozilla accounts has change their input field identifiers on stage,
including submit buttons with no common identifier.
The previous URL match had trouble with an empty querystring, like
/accounts/profile/?
@rafeerahman
Copy link
Contributor

Thanks, confirming this fixes the failing tests with the new account creation auth page. Will only work on dev right now since there is maintenance going on with stage, once that maintenance is done it will pass.

Ran locally and here https://github.com/mozilla/fx-private-relay/actions/runs/7657716934.

@jwhitlock jwhitlock added this pull request to the merge queue Jan 25, 2024
Merged via the queue into main with commit 1fdb597 Jan 25, 2024
28 of 30 checks passed
@jwhitlock jwhitlock deleted the fix-e2e-for-fxa-changes branch January 25, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants