E2E fixes for FxA auth page changes (2024-03-19) #4518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
groovecoder
approved these changes
Mar 19, 2024
There was a problem hiding this comment.
Woohoo this fixed it! https://github.com/mozilla/fx-private-relay/actions/runs/8350090298
jwhitlock
reviewed
Mar 25, 2024
| this.passwordInputField = page.getByTestId('new-password-input-field'); | ||
| this.passwordConfirmInputField = page.getByTestId('verify-password-input-field'); | ||
| this.ageInputField = page.getByTestId('age-input-field'); | ||
| this.passwordInputField = process.env["E2E_TEST_ENV"] === "prod" ? page.locator('#password') : page.getByTestId('new-password-input-field'); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the FxA production environment, changes for account creation changes handled in #4346 were reverted, causing failing tests for Relay prod. The changes were not reverted for the stage FxA auth page as of today, so no updates are needed there.
Checklist (Definition of Done)
/frontend/src/styles/tokens.scss).