MPP-3753: Disable DomainAddress address field updates #4519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
say-yawn
requested changes
Mar 21, 2024
emails/models.py
Outdated
| class DomainAddrUpdateException(CannotMakeAddressException): | ||
| """Exception raised when attempting to edit an existing domain address field.""" | ||
|
|
||
| default_code = "address_exists" |
There was a problem hiding this comment.
Suggested change
| default_code = "address_exists" | |
| default_code = "address_not_editable" |
The previous error code makes it confusing to another error where the domain address cannot be created because an address exists.
There was a problem hiding this comment.
Addressed these changes, 08417ec
| @@ -560,6 +560,49 @@ def test_patch_domainaddress_read_only_mask_type( | |||
| assert get_glean_event(caplog) is None | |||
|
|
|||
|
|
|||
| def test_patch_domainaddress_address_fails( | |||
Put a PR up here, mozilla-l10n/fx-private-relay-l10n#169. Also looks like |
say-yawn
approved these changes
Mar 21, 2024
jwhitlock
added a commit
that referenced
this pull request
Mar 26, 2024
This was handled in PR #4519 by making it an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes MPP-3753.
New feature description
Disables updates to the address field for DomainAddress'.
Screenshot (if applicable)
Not applicable.
How to test
Log in or create account with premium emails and a domain locally
Create a new domain mask
Go to api/v1/docs/#/domainaddresses/domainaddresses_list, select GET /api/v1/domainaddresses/, click “Try it out”, scroll down and then click “Execute”, to get the list of domain addresses. Get the ID for the new domain mask.
Still on api/v1/docs/#/domainaddresses/domainaddresses_list, select PATCH /api/v1/domainaddresses/{id}/. Click “Try it out”, enter the ID for the new domain mask, and enter JSON that changes the address, such as {"address": "Huh-You-Can-Change-This"}.
Checklist (Definition of Done)
/frontend/src/styles/tokens.scss).