Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MPP-3753: More test changes for write-once DomainAddress address #4546

Merged
merged 2 commits into from
Mar 27, 2024
Merged

MPP-3753: More test changes for write-once DomainAddress address #4546

merged 2 commits into from
Mar 27, 2024

Conversation

jwhitlock
Copy link
Member

This is follow-on work for PR #4519:

  • Remove the TODO and the address test case for test_patch_domainaddress_read_only. If a caller tries to change the address, it is a 400 error, not a 200, as tested in test_patch_domainaddress_address_fails
  • Wrap a comment to under 88 lines. This will be enforced soon with ruff.

@jwhitlock
Remove TODO testcase for MPP-3753
f2e4f97 
This was handled in PR #4519 by making it an error.
@jwhitlock
Wrap long comment
bdbffd9
@jwhitlock jwhitlock requested a review from rafeerahman March 26, 2024 21:44
rafeerahman
rafeerahman approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@rafeerahman rafeerahman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good.

@jwhitlock jwhitlock added this pull request to the merge queue Mar 27, 2024
Merged via the queue into main with commit 2ecbbdc Mar 27, 2024
28 checks passed
@jwhitlock jwhitlock deleted the more-tests-domainaddress-mpp-3753 branch March 27, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafeerahman rafeerahman rafeerahman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jwhitlock @rafeerahman