Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #971 - Add border-radius and box shadow to error message #980

Merged
merged 2 commits into from
Aug 4, 2021

Conversation

codemist
Copy link
Collaborator

@codemist codemist commented Jul 29, 2021

Added border-radius and box-shadow to the .error class.

Note: The color/box-shadow variable has yet to be updated to follow Protocol/Nebula convention. The Figma reference is dated at the moment.

@codemist codemist requested a review from maxxcrawford July 30, 2021 19:31
Copy link
Contributor

@maxxcrawford maxxcrawford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you include a screenshot or steps to reproduce? I'm having trouble triggering an error.

Also – should this same border/drop-shadow apply to the green success message?

@codemist
Copy link
Collaborator Author

codemist commented Aug 3, 2021

Preview:

image

How I reproduced it:

I typed in a long input in the 'search your domain' field in the mpp-dashbaord-header div.

Copy link
Collaborator Author

@codemist codemist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

static/scss/partials/main.scss Show resolved Hide resolved
static/scss/partials/main.scss Show resolved Hide resolved
static/scss/partials/main.scss Show resolved Hide resolved
@codemist codemist requested a review from maxxcrawford August 3, 2021 17:32
static/scss/partials/main.scss Show resolved Hide resolved
static/scss/partials/main.scss Show resolved Hide resolved
Copy link
Contributor

@maxxcrawford maxxcrawford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you resolve the conflicts? This is good to go.

@maxxcrawford maxxcrawford merged commit 87b50b8 into main Aug 4, 2021
@maxxcrawford maxxcrawford deleted the error-msg branch August 4, 2021 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants