-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #971 - Add border-radius and box shadow to error message #980
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you include a screenshot or steps to reproduce? I'm having trouble triggering an error.
Also – should this same border/drop-shadow apply to the green success message?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you resolve the conflicts? This is good to go.
Added
border-radius
andbox-shadow
to the.error
class.Note: The color/box-shadow variable has yet to be updated to follow Protocol/Nebula convention. The Figma reference is dated at the moment.