Merge pull request #15370 from mozilla/fxa-7136

feat(auth): Update Google authorization endpoint to not show disclaimer
mozilla · May 24, 2023 · 2fdd6fd · 2fdd6fd
2 parents ee4f6cb + f75644f
commit 2fdd6fd
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/packages/fxa-content-server/app/scripts/views/mixins/third-party-auth-mixin.js b/packages/fxa-content-server/app/scripts/views/mixins/third-party-auth-mixin.js
@@ -102,6 +102,8 @@ export default {
       access_type: 'offline',
       prompt: 'consent',
       response_type: 'code',
+      disallow_webview: true,
+      ack_webview_shutdown:'2024-09-30'
     };
     /* eslint-enable camelcase */
     for (const p in params) {
@@ -148,7 +150,7 @@ export default {
       access_type: 'offline',
       prompt: 'consent',
       response_type: 'code id_token',
-      response_mode: 'form_post',
+      response_mode: 'form_post'
     };
     /* eslint-enable camelcase */
     for (const p in params) {

diff --git a/packages/fxa-content-server/app/tests/spec/views/mixins/third-party-auth-mixin.js b/packages/fxa-content-server/app/tests/spec/views/mixins/third-party-auth-mixin.js
@@ -145,7 +145,7 @@ describe('views/mixins/third-party-auth-mixin', function () {
       )
     );
 
-    assert.equal(mockInput.setAttribute.args.length, 21);
+    assert.equal(mockInput.setAttribute.args.length, 27);
 
     assertInputEl(mockInput, 'client_id', config.googleAuthConfig.clientId);
     assertInputEl(mockInput, 'scope', 'openid email profile');
@@ -164,8 +164,10 @@ describe('views/mixins/third-party-auth-mixin', function () {
     assertInputEl(mockInput, 'access_type', 'offline');
     assertInputEl(mockInput, 'prompt', 'consent');
     assertInputEl(mockInput, 'response_type', 'code');
+    assertInputEl(mockInput, 'disallow_webview', true);
+    assertInputEl(mockInput, 'ack_webview_shutdown', '2024-09-30');
 
-    assert.equal(mockForm.appendChild.args.length, 7);
+    assert.equal(mockForm.appendChild.args.length, 9);
     assert.isTrue(mockForm.submit.calledOnce);
   });