feat(auth): Update Google authorization endpoint to not show disclaimer #15370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenba
reviewed
May 24, 2023
| @@ -148,7 +150,7 @@ export default { | |||
| access_type: 'offline', | |||
| prompt: 'consent', | |||
| response_type: 'code id_token', | |||
| response_mode: 'form_post', | |||
| response_mode: 'form_post' | |||
There was a problem hiding this comment.
your auto formatting might be different than my auto formatting for this trailing comma 😄
chenba
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: https://mozilla-hub.atlassian.net/browse/FXA-7136
Checklist
Other information (Optional)
I tested this in the iOS simulator and did not see any error messages on Google sign-in page. It is hard to verify this with Pocket unless it is in production. This is safe to land since users have to opt in to third party auth anyways.