Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CCITT Group 4 fax mask decompression problem #4379

Closed
bsl-zcs opened this issue Mar 3, 2014 · 3 comments · Fixed by #5136
Closed

CCITT Group 4 fax mask decompression problem #4379

bsl-zcs opened this issue Mar 3, 2014 · 3 comments · Fixed by #5136
Labels
image-quality

Comments

@bsl-zcs
Copy link
Contributor

bsl-zcs commented Mar 3, 2014

A buffer returned by CCITTFaxStream_readBlock is shorter than it should be, and resulting image has the odd line at the bottom.

http://www.pnml.kz/pdfexample/ccittfaxmask2.pdf
@bsl-zcs bsl-zcs mentioned this issue Mar 3, 2014
Merged
@Snuffleupagus Snuffleupagus mentioned this issue Apr 12, 2014
Closed
@bsl-zcs bsl-zcs mentioned this issue Jun 26, 2014
Closed
@timvandermeij
Copy link
Contributor

Another example: http://www.pnml.kz/pdfexample/multiimage2.pdf (from #4996).

@Snuffleupagus Snuffleupagus mentioned this issue Aug 5, 2014
Closed
@timvandermeij timvandermeij mentioned this issue Aug 5, 2014
Merged
@CodingFabian
Copy link
Contributor

@bsl-zcs i assume you created the example pdfs yourself? would you be ok to donate them to the project as reduced test pdf for regression testing?

@bsl-zcs
Copy link
Contributor Author

bsl-zcs commented Aug 7, 2014

Of course it's ok. The smaller one (ccittfaxmask2.pdf) was made for this exact purpose.

@Snuffleupagus Snuffleupagus mentioned this issue Dec 29, 2014
Merged
@timvandermeij timvandermeij mentioned this issue Feb 14, 2015
Merged
speedplane pushed a commit to speedplane/pdf.js that referenced this issue Feb 24, 2015
@Snuffleupagus
Add a reduced test case for issue 4379
dc25b68 
This should have been part of PR 5136.

Based on comments mozilla#4379 (comment) and mozilla#4379 (comment), it should be OK to include the PDF file in the repo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
image-quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Properly set this.eof in CCITTFaxStream timvandermeij/pdf.js
4 participants
@CodingFabian @yurydelendik @timvandermeij @bsl-zcs