Fix CCITTStream regression by byte-aligning rows before checking EOL marker

[timvandermeij]

Fixes #5726.

It turns out that byte-aligning rows needs to happen before checking for an EOL marker. Older versions of the Poppler code did this (https://github.com/davidben/poppler/blob/master/poppler/Stream.cc#L1642), as well as libpdf++ (https://github.com/match41/sumpdf/blob/master/libpdfdoc/src/stream/CCITTFaxStream.cc#L403).

[timvandermeij]

/botio-linux preview

[pdfjsbot]

From: Bot.io (Linux)

---

Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/435fdf1a9176ca0/output.txt

[pdfjsbot]

From: Bot.io (Linux)

---

Success

Full output at http://107.21.233.14:8877/435fdf1a9176ca0/output.txt

Total script time: 0.80 mins

Published

• Viewer: http://107.21.233.14:8877/435fdf1a9176ca0/web/viewer.html
• B2G Viewer: http://107.21.233.14:8877/435fdf1a9176ca0/extensions/b2g/content/web/viewer.html
• Extension: http://107.21.233.14:8877/435fdf1a9176ca0/extensions/firefox/pdf.js.xpi

[timvandermeij]

/botio test

[pdfjsbot]

From: Bot.io (Linux)

---

Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/ce69f3fe29aa66f/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.22.172.223:8877/6b5728fa20f1699/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Success

Full output at http://107.22.172.223:8877/6b5728fa20f1699/output.txt

Total script time: 17.56 mins

• Font tests: Passed
• Unit tests: Passed
• Regression tests: Passed

[pdfjsbot]

From: Bot.io (Linux)

---

Success

Full output at http://107.21.233.14:8877/ce69f3fe29aa66f/output.txt

Total script time: 23.38 mins

• Font tests: Passed
• Unit tests: Passed
• Regression tests: Passed

[Snuffleupagus]

I can confirm that this fixes the regression, and I'm impressed with the quick turnaround, however I'm a bit nervous about this patch ;-)
@timvandermeij Since you (basically) revert one of the code changes from PR #5136, have you gone through all those files to ensure that this patch won't regress any of them (our test coverage is probably not perfect).
I've looked at most of those, and everything still appears to work, but I'd like you to reassurance me that you've looked at them too before I'm comfortable with merging this :-)

[timvandermeij]

@Snuffleupagus I should indeed have mentioned that! I have tested all PDF files from the following issues:

• CCITTFaxStream regression - only a small part of the image is rendered correctly #5726 (1 file)
• PDF not rendered #5592 (1 file)
• Horizontal Lines Across Whole Document #5133 (1 file)
• Spurious horizontal lines are drawn #5385 (1 file)
• CCITT Group 4 fax mask decompression problem #4379 (2 files)
• https://bugzilla.mozilla.org/show_bug.cgi?id=776608 (5 files)
• http://www.institute-christ-king.org/latin-mass-resources/sacred-music (tested many files, not all 200 since they are all similar and generated by the same generator)

All those PDFs render fine with this patch. The ones that were already fixed render the same with this patch and the one from your issue now renders completely with this patch.

[Snuffleupagus]

I figured that you did test them, but I just wanted to make sure. Thank you!

/botio makeref

[pdfjsbot]

From: Bot.io (Linux)

---

Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/141964a4dee7f07/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/0347e4c8b711f05/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Failed

Full output at http://107.22.172.223:8877/0347e4c8b711f05/output.txt

Total script time: 1.08 mins

• Lint: Passed
• Make references: FAILED

[pdfjsbot]

From: Bot.io (Linux)

---

Success

Full output at http://107.21.233.14:8877/141964a4dee7f07/output.txt

Total script time: 22.98 mins

• Lint: Passed
• Make references: Passed
• Check references: Passed