Revert "Fix the remaining no-var failures, which couldn't be handled automatically, in the src/core/evaluator.js file" (PR 13344 follow-up)
#13371
Conversation
…d automatically, in the `src/core/evaluator.js` file" (PR 13344 follow-up) This reverts commit 0ef9b5a, since it cases a lot of warnings (see below) *locally* with e.g. the document from issue 9627. Strangely enough, this only occurs with `gulp server`-mode and the actual builds are apparently fine. It seems that this *may* be some unfortunate interaction with the old Babel-plugin that's used together with SystemJS. ``` Warning: getTextContent - ignoring ExtGState: "FormatError: ExtGState should be a dictionary.". ``` Rather than taking the risk that this could actually cover a more serious bug, and since I cannot immediately figure out what's wrong, it thus seem safest to revert this for now and we can (carefully) revisit this once SystemJS has been removed (see PR 12563).
Snuffleupagus
force-pushed
the
revert-evaluator-manual-no-var
branch
from
3d54392 to
75208d3
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/f61e20164fa4461/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/2b458d9255ebe7f/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/f61e20164fa4461/output.txt Total script time: 26.24 mins
Image differences available at: http://54.67.70.0:8877/f61e20164fa4461/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/2b458d9255ebe7f/output.txt Total script time: 29.53 mins
Image differences available at: http://3.101.106.178:8877/2b458d9255ebe7f/reftest-analyzer.html#web=eq.log |
|
Good call. It also looks like this should just work; very strange indeed. |
This reverts commit 0ef9b5a, since it cases a lot of warnings (see below) locally with e.g. the document from issue #9627.
Strangely enough, this only occurs with
gulp server-mode and the actual builds are apparently fine. It seems that this may be some unfortunate interaction with the old Babel-plugin that's used together with SystemJS.Rather than taking the risk that this could actually cover a more serious bug, and since I cannot immediately figure out what's wrong, it thus seem safest to revert this for now and we can (carefully) revisit this once SystemJS has been removed (see PR #12563).
Reverts part of PR #13344.