Enable the ESLint no-var rule in the src/core/evaluator.js file
#19050
Conversation
Snuffleupagus
force-pushed
the
evaluator-no-var
branch
from
3086ca9 to
595e73d
Compare
|
/botio test |
Snuffleupagus
force-pushed
the
evaluator-no-var
branch
from
595e73d to
52c5f65
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This was previously attempted in PR 13371, but had to be reverted because of issues related to SystemJS (which has since been removed). Also, while unrelated, shortens an existing conditional assignment.
Snuffleupagus
force-pushed
the
evaluator-no-var
branch
from
52c5f65 to
c082169
Compare
|
/botio unittest |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/7e742bdb24ddbfc/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/4076d729178abff/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/4076d729178abff/output.txt Total script time: 2.52 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/7e742bdb24ddbfc/output.txt Total script time: 6.67 mins
|
|
/botio browsertest |
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/83d4889a6eb8438/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/ff77a8635686132/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/ff77a8635686132/output.txt Total script time: 20.71 mins
Image differences available at: http://54.241.84.105:8877/ff77a8635686132/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/83d4889a6eb8438/output.txt Total script time: 25.60 mins
|
|
Good that we can do this now; thanks! |
This was previously attempted in PR #13371, but had to be reverted because of issues related to SystemJS (which has since been removed).
Also, while unrelated, shortens an existing conditional assignment.