[api-minor] Get rid of CSS transform on each annotation in the annotation layer #15036

calixteman · 2022-06-13T09:14:40Z

each annotation has its coordinates/dimensions expressed in percentage,
hence it's correctly positioned whatever the scale factor is;
the font sizes are expressed in percentage too and the main font size
is scaled thanks a css var (--scale-factor);
the rotation is now applied on the div annotationLayer;
this patch improve the rendering of some strings where the glyph spacing
was not correct (it's a Firefox bug);
it helps to simplify the code and it should slightly improve the update of
page (on zoom or rotation).

Snuffleupagus · 2022-06-13T09:43:02Z

I'm assuming, based on a very brief look at the code, that we no longer can easily avoid having both a --scale-factor and a --zoom-factor CSS variable?

src/display/annotation_layer.js

web/annotation_layer_builder.js

Snuffleupagus · 2022-06-13T18:13:32Z

Also, with the last round of changes it seems that

pdf.js/src/display/editor/annotation_editor_layer.js

Lines 426 to 432 in 89cebcb

    
             /** 
        
              * Get the zoom factor. 
        
              * @returns {number} 
        
              */ 
        
             get zoomFactor() { 
        
               return this.viewport.scale / PixelsPerInch.PDF_TO_CSS_UNITS; 
        
             }

is now unused. Are you planning on using that one later, or can it be removed?

Snuffleupagus · 2022-06-14T09:20:55Z

/botio test

pdfjsbot · 2022-06-14T09:20:56Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/11c6759447a1ac9/output.txt

pdfjsbot · 2022-06-14T09:20:56Z

From: Bot.io (Windows)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/3691ae9085a7771/output.txt

pdfjsbot · 2022-06-14T09:47:02Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/11c6759447a1ac9/output.txt

Total script time: 26.09 mins

Font tests: Passed
Unit tests: FAILED
Integration Tests: Passed
Regression tests: FAILED

  different ref/snapshot: 158

Image differences available at: http://54.241.84.105:8877/11c6759447a1ac9/reftest-analyzer.html#web=eq.log

pdfjsbot · 2022-06-14T09:49:18Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/3691ae9085a7771/output.txt

Total script time: 28.35 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: FAILED
Regression tests: FAILED

  different ref/snapshot: 69

Image differences available at: http://54.193.163.58:8877/3691ae9085a7771/reftest-analyzer.html#web=eq.log

calixteman · 2022-06-14T11:36:02Z

/botio browsertest

pdfjsbot · 2022-06-14T11:36:04Z

From: Bot.io (Linux m4)

Received

Command cmd_browsertest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/277aa41f8d821d0/output.txt

pdfjsbot · 2022-06-14T11:36:04Z

From: Bot.io (Windows)

Received

Command cmd_browsertest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/88cb25d1f3c8a30/output.txt

pdfjsbot · 2022-06-14T11:57:04Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/88cb25d1f3c8a30/output.txt

Total script time: 20.99 mins

Regression tests: FAILED

  different ref/snapshot: 69

Image differences available at: http://54.193.163.58:8877/88cb25d1f3c8a30/reftest-analyzer.html#web=eq.log

pdfjsbot · 2022-06-14T11:57:59Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/277aa41f8d821d0/output.txt

Total script time: 21.90 mins

Regression tests: FAILED

  different ref/snapshot: 159
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/277aa41f8d821d0/reftest-analyzer.html#web=eq.log

src/display/base_factory.js

calixteman · 2022-06-14T14:50:01Z

/botio browsertest

pdfjsbot · 2022-06-14T14:50:03Z

From: Bot.io (Linux m4)

Received

Command cmd_browsertest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/1fe7461cdabf122/output.txt

pdfjsbot · 2022-06-14T14:50:03Z

From: Bot.io (Windows)

Received

Command cmd_browsertest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/24c633e5dd31ec1/output.txt

src/display/annotation_layer.js

pdfjsbot · 2022-06-14T15:10:53Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/24c633e5dd31ec1/output.txt

Total script time: 20.83 mins

Regression tests: FAILED

  different ref/snapshot: 69

Image differences available at: http://54.193.163.58:8877/24c633e5dd31ec1/reftest-analyzer.html#web=eq.log

timvandermeij

Fixes #14935 I presume? Looks good to me with these comments addressed.

src/display/annotation_layer.js

src/display/base_factory.js

- each annotation has its coordinates/dimensions expressed in percentage, hence it's correctly positioned whatever the scale factor is; - the font sizes are expressed in percentage too and the main font size is scaled thanks a css var (--scale-factor); - the rotation is now applied on the div annotationLayer; - this patch improve the rendering of some strings where the glyph spacing was not correct (it's a Firefox bug); - it helps to simplify the code and it should slightly improve the update of page (on zoom or rotation).

calixteman · 2022-06-18T15:55:50Z

/botio test

pdfjsbot · 2022-06-18T15:55:52Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/ddac5c9b7097f20/output.txt

pdfjsbot · 2022-06-18T15:55:52Z

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/b192910d4535352/output.txt

pdfjsbot · 2022-06-18T16:21:25Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/ddac5c9b7097f20/output.txt

Total script time: 25.53 mins

Font tests: Passed
Unit tests: FAILED
Integration Tests: Passed
Regression tests: FAILED

  different ref/snapshot: 160

Image differences available at: http://54.241.84.105:8877/ddac5c9b7097f20/reftest-analyzer.html#web=eq.log

pdfjsbot · 2022-06-18T16:24:08Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/b192910d4535352/output.txt

Total script time: 28.25 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: FAILED
Regression tests: FAILED

  different ref/snapshot: 69

Image differences available at: http://54.193.163.58:8877/b192910d4535352/reftest-analyzer.html#web=eq.log

calixteman · 2022-06-19T09:36:23Z

/botio makeref

pdfjsbot · 2022-06-19T09:36:24Z

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/6c8f21f60953ec8/output.txt

pdfjsbot · 2022-06-19T09:36:24Z

From: Bot.io (Windows)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/51819cac3333fe7/output.txt

pdfjsbot · 2022-06-19T09:58:20Z

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/51819cac3333fe7/output.txt

Total script time: 21.91 mins

Lint: Passed
Make references: Passed
Check references: Passed

pdfjsbot · 2022-06-19T09:59:54Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/6c8f21f60953ec8/output.txt

Total script time: 23.49 mins

Lint: Passed
Make references: Passed
Check references: Passed

Avoid having overflowing sections (#15036 follow-up)

calixteman added the form-acroform label Jun 13, 2022

calixteman requested review from Snuffleupagus and timvandermeij June 13, 2022 09:14

Snuffleupagus changed the title ~~Get rid of CSS transform on each annotation in the annotation layer~~ [api-minor] Get rid of CSS transform on each annotation in the annotation layer Jun 13, 2022

Snuffleupagus reviewed Jun 13, 2022

View reviewed changes

src/display/annotation_layer.js Show resolved Hide resolved

calixteman force-pushed the remove_scale branch 2 times, most recently from 333a597 to d72e819 Compare June 13, 2022 17:40

Snuffleupagus reviewed Jun 13, 2022

View reviewed changes

web/annotation_layer_builder.js Outdated Show resolved Hide resolved

calixteman force-pushed the remove_scale branch from d72e819 to 1252733 Compare June 13, 2022 18:21

calixteman force-pushed the remove_scale branch from 1252733 to cd45eb5 Compare June 14, 2022 11:35

Snuffleupagus reviewed Jun 14, 2022

View reviewed changes

src/display/base_factory.js Outdated Show resolved Hide resolved

calixteman force-pushed the remove_scale branch from cd45eb5 to b9d7d1e Compare June 14, 2022 14:49

Snuffleupagus reviewed Jun 14, 2022

View reviewed changes

src/display/annotation_layer.js Show resolved Hide resolved

Snuffleupagus reviewed Jun 14, 2022

View reviewed changes

src/display/annotation_layer.js Outdated Show resolved Hide resolved

timvandermeij reviewed Jun 18, 2022

View reviewed changes

src/display/annotation_layer.js Outdated Show resolved Hide resolved

src/display/annotation_layer.js Outdated Show resolved Hide resolved

src/display/base_factory.js Outdated Show resolved Hide resolved

calixteman linked an issue Jun 18, 2022 that may be closed by this pull request

Get rid of transform in the annotation layer #14935

Closed

calixteman force-pushed the remove_scale branch from c4fc41e to e2db9ba Compare June 18, 2022 15:55

calixteman requested review from timvandermeij and Snuffleupagus June 18, 2022 16:35

Snuffleupagus approved these changes Jun 19, 2022

View reviewed changes

calixteman merged commit 54777b4 into mozilla:master Jun 19, 2022

timvandermeij removed their request for review June 19, 2022 11:18

This was referenced Jun 19, 2022

Prevent the annotationLayer from overflowing (PR 15036 follow-up) #15061

Closed

Some PopupAnnotation trigger-areas are too small after PR 15036 #15063

Closed

calixteman added a commit to calixteman/pdf.js that referenced this pull request Jun 19, 2022

Avoid having overflowing sections (mozilla#15036 follow-up)

4d8304c

calixteman added a commit to calixteman/pdf.js that referenced this pull request Jun 19, 2022

Avoid having overflowing sections (mozilla#15036 follow-up)

0efa6c0

calixteman added a commit to calixteman/pdf.js that referenced this pull request Jun 19, 2022

Avoid having overflowing sections (mozilla#15036 follow-up)

af47a0b

Snuffleupagus added a commit that referenced this pull request Jun 20, 2022

Merge pull request #15064 from calixteman/rescale_followup

8d154d7

Avoid having overflowing sections (#15036 follow-up)

Snuffleupagus mentioned this pull request Jul 4, 2022

Fix the Popup-trigger for FileAttachmentAnnotationElement (PR 15036 follow-up) #15125

Merged

rousek pushed a commit to signosoft/pdf.js that referenced this pull request Aug 10, 2022

Avoid having overflowing sections (mozilla#15036 follow-up)

a1190bb

calixteman mentioned this pull request Dec 6, 2022

Set the dimensions of the various layers at their creation #15770

Merged

ZeroXClem mentioned this pull request Aug 12, 2024

[Snyk] Upgrade pdfjs-dist from 2.9.359 to 2.16.105 ZeroXClem/metamesa#3

Closed

earthywh mentioned this pull request Sep 24, 2024

[Snyk] Upgrade pdfjs-dist from 2.6.347 to 2.16.105 earthywh/filestash#1

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[api-minor] Get rid of CSS transform on each annotation in the annotation layer #15036

[api-minor] Get rid of CSS transform on each annotation in the annotation layer #15036

calixteman commented Jun 13, 2022

Snuffleupagus commented Jun 13, 2022

Snuffleupagus commented Jun 13, 2022

Snuffleupagus commented Jun 14, 2022

pdfjsbot commented Jun 14, 2022

pdfjsbot commented Jun 14, 2022

pdfjsbot commented Jun 14, 2022

pdfjsbot commented Jun 14, 2022

calixteman commented Jun 14, 2022

pdfjsbot commented Jun 14, 2022

pdfjsbot commented Jun 14, 2022

pdfjsbot commented Jun 14, 2022

pdfjsbot commented Jun 14, 2022

calixteman commented Jun 14, 2022

pdfjsbot commented Jun 14, 2022

pdfjsbot commented Jun 14, 2022

pdfjsbot commented Jun 14, 2022

timvandermeij left a comment

calixteman commented Jun 18, 2022

pdfjsbot commented Jun 18, 2022

pdfjsbot commented Jun 18, 2022

pdfjsbot commented Jun 18, 2022

pdfjsbot commented Jun 18, 2022

calixteman commented Jun 19, 2022

pdfjsbot commented Jun 19, 2022

pdfjsbot commented Jun 19, 2022

pdfjsbot commented Jun 19, 2022

pdfjsbot commented Jun 19, 2022

[api-minor] Get rid of CSS transform on each annotation in the annotation layer #15036

[api-minor] Get rid of CSS transform on each annotation in the annotation layer #15036

Conversation

calixteman commented Jun 13, 2022

Snuffleupagus commented Jun 13, 2022

Snuffleupagus commented Jun 13, 2022

Snuffleupagus commented Jun 14, 2022

pdfjsbot commented Jun 14, 2022

From: Bot.io (Linux m4)

Received

pdfjsbot commented Jun 14, 2022

From: Bot.io (Windows)

Received

pdfjsbot commented Jun 14, 2022

From: Bot.io (Linux m4)

Failed

pdfjsbot commented Jun 14, 2022

From: Bot.io (Windows)

Failed

calixteman commented Jun 14, 2022

pdfjsbot commented Jun 14, 2022

From: Bot.io (Linux m4)

Received

pdfjsbot commented Jun 14, 2022

From: Bot.io (Windows)

Received

pdfjsbot commented Jun 14, 2022

From: Bot.io (Windows)

Failed

pdfjsbot commented Jun 14, 2022

From: Bot.io (Linux m4)

Failed

calixteman commented Jun 14, 2022

pdfjsbot commented Jun 14, 2022

From: Bot.io (Linux m4)

Received

pdfjsbot commented Jun 14, 2022

From: Bot.io (Windows)

Received

pdfjsbot commented Jun 14, 2022

From: Bot.io (Windows)

Failed

timvandermeij left a comment

Choose a reason for hiding this comment

calixteman commented Jun 18, 2022

pdfjsbot commented Jun 18, 2022

From: Bot.io (Linux m4)

Received

pdfjsbot commented Jun 18, 2022

From: Bot.io (Windows)

Received

pdfjsbot commented Jun 18, 2022

From: Bot.io (Linux m4)

Failed

pdfjsbot commented Jun 18, 2022

From: Bot.io (Windows)

Failed

calixteman commented Jun 19, 2022

pdfjsbot commented Jun 19, 2022

From: Bot.io (Linux m4)

Received

pdfjsbot commented Jun 19, 2022

From: Bot.io (Windows)

Received

pdfjsbot commented Jun 19, 2022

From: Bot.io (Windows)

Success

pdfjsbot commented Jun 19, 2022

From: Bot.io (Linux m4)

Success