Prevent the annotationLayer from overflowing (PR 15036 follow-up)

[Snuffleupagus]

After the changes in PR #15036, in some cases the annotationLayer may cause an empty area to appear after the last page; one example is f1040.pdf in the test-suite.
This patch simply does the same thing as we already do in the textLayer, that is simply hide any overflow.

---

[calixteman]

Is the overflow only due to the non-integer width/height ?

[Snuffleupagus]

Is the overflow only due to the non-integer width/height ?

Unfortunately not, at least in my testing. (The second patch only fixes an inconsistency.)

[calixteman]

It's liekely because of:
font-size: calc(100px * var(--scale-factor));.

Maybe there is something in em which causes the overflow.

[Snuffleupagus]

Wait, setting overflow: hidden breaks PopupAnnotations since those need to overflow the container :-(

[calixteman]

I set:
https://github.com/mozilla/pdf.js/blob/master/web/annotation_layer_builder.css#L44
in order to use font-sizewith a percentage.
But it appears that because of that every section is now overflowing, I don't really understand why...
Anyway as far as I can tell there are 2 ways to fix that:

• add an overflow:hidden for sections;
• remove the font-size as a percentage and use calc(....) instead.

We can either backout my patch or wait a little and I'll push something tomorrow.
Of course, please feel free to have a better idea than mines... ;)

[Snuffleupagus]

• add an overflow:hidden for sections;

Unfortunately I don't believe that'll work, since in my quick testing that still breaks PopupAnnotations as mentioned in #15061 (comment).

[Snuffleupagus]

I'm going to close this, given PR #15064, however I intend to submit the second commit separately since that still makes sense for consistency in my opinion.