Import l10n files from mozilla-aurora [WIP] #3766

timvandermeij · 2013-10-03T21:48:36Z

This PR fixes #3242 and supersedes #3762. It adds a Makefile utility called importl10n (call: node make importl10n) that fetches the latest l10n files from mozilla-aurora. This implies that translations should now only be done at the central Mozilla repository and not here anymore. This avoids users translating strings here that are already translated by the Firefox team and makes sure that translations are always synchronized between Firefox and PDF.js.

Note that this tool keeps our metadata.inc files because the Firefox team does not translate those.

The PR changes the regex used in node make firefox a bit to allow the new languages codes from mozilla-aurora, in particular three-letter codes.

Move the download logic to external/importL10n (say locales.js) in a function downloadLanguageFiles(lang, dest).
Squash the last three commits.
Update the wiki with the message from CONTRIBUTING.md.
Review comment on text in CONTRIBUTING.md

Snuffleupagus · 2013-10-04T08:17:49Z

import_locales.js

+
+// Defines all languages that have a translation at mozilla-aurora.
+// This is used in make.js for the importl10n command.
+function getlangcodes() {


Nit: use lowerCamelCase, i.e. getLangCodes.

Don't know what I was thinking there. Fixed in new commit :)

waddlesplash · 2013-10-17T23:08:14Z

Can this be merged?

yurydelendik · 2014-03-17T14:20:40Z

@timvandermeij Okay, let's do this:

rebase to the latest master
add a README.md file that will tell where we got this files, mention MPL license is used for all except 'en-US' there (probably we shall include the license file too)
remove 'ja-JP-mac' from the list
make the initial import, which will include all new files
not sure about this one, but remove locales that we not present in the l10n-aurora

Last two can be done in the separate commit.

Snuffleupagus · 2014-03-17T17:02:51Z

I have a question in connection with this: Does this mean that, going forward, all PRs that update locales (except for en-US of course) will be rejected?

The reason that I think we should make a decision about this is the following case:
When new functionality (adding locale strings) lands in PDF.js, it can easily take at least two months for it to land in Aurora. During this time, those strings will be untranslated in PDF.js.
Do we want to accept PRs adding missing strings, until such a time that they are available in Aurora?

I believe that it would be a good idea make a decision about this, and then preferably adding this information to the Wiki and CONTRIBUTING.md.

yurydelendik · 2014-03-17T17:13:17Z

I have a question in connection with this: Does this mean that, going forward, all PRs that update locales (except for en-US of course) will be rejected?

Good question. But can we afford to do micro-merging? How about we will still accept the pull request, but we will override the patches/changes will new sync.

... and then preferably adding this information to the Wiki and CONTRIBUTING.md.

Yes, we shall mention that there

Snuffleupagus · 2014-03-17T17:29:00Z

How about we will still accept the pull request, but we will override the patches/changes will new sync.

That's exactly what I've been thinking too!

timvandermeij · 2014-03-18T23:05:50Z

@yurydelendik Sounds like a good plan. One question though: where would I put the README.md file?

yurydelendik · 2014-03-18T23:06:56Z

where would I put the README.md file?

https://github.com/mozilla/pdf.js/tree/master/l10n is a good place for it

yurydelendik · 2014-03-20T21:17:02Z

l10n/README.md

@@ -0,0 +1 @@
+Most of the files in this folder (except for the `en-US` folder and the `metadata.inc` files) have been imported from the Firefox Aurora branch, which is located at https://mxr.mozilla.org/l10n-mozilla-aurora/source. Those files are licensed under the MPL license. You can obtain a copy of the license at http://mozilla.org/MPL/2.0.


Some of the files license under apache2. We can reword "Those files are licensed under the MPL license. " -> "Some of the files are licensed under the MPL license."

Could you split/format text at 80 chars margin?

yurydelendik · 2014-03-20T21:18:51Z

move import_locales.js to the external/importL10n/ folder

Snuffleupagus · 2014-03-21T13:18:12Z

CONTRIBUTING.md

-If you are developing a custom solution, first check examples at https://github.com/mozilla/pdf.js#learning and search existing issues. If this does not help, please prepare short well-documented example that demonstrate the problem and make it accessible online on your website, jsbin, github, etc. before opening a new issue or contacting us on the IRC channel -- keep in mind that just code snippets won't help us troubleshoot the problem. The issues that do not provide enough details will be closed as invalid/incomplete.
+If you are developing a custom solution, first check the examples at https://github.com/mozilla/pdf.js#learning and search existing issues. If this does not help, please prepare a short well-documented example that demonstrates the problem and make it accessible online on your website, JS Bin, GitHub, etc. before opening a new issue or contacting us on the IRC channel -- keep in mind that just code snippets won't help us troubleshoot the problem.
+
+Note that the translations for PDF.js in the `l10n` folder are synchronized with the Aurora branch of Mozilla Firefox. This means that we will still accept pull requests that update translations (because it can take a few weeks before the most recent translations are in the Aurora branch), but keep in mind that the changes will be overwritten when we synchronize again.


Shouldn't this more explicitly state that we only will accept PRs that add strings currently missing in Aurora, i.e. no PRs which changes existing strings (since they are pointless)?
Also, since PDF.js spends one cycle (= six weeks) on Nightly before being uplifted to Aurora, I suggest changing "because it can take a few weeks" to "because it will take at least six weeks".

Good point! I will definitely change that.

…ed with the proper language codes

…nc files

…and README.md

timvandermeij · 2014-03-22T16:16:08Z

Superseded by #4504.

timvandermeij mentioned this pull request Oct 3, 2013

Import l10n files from mozilla-aurora [WIP] #3762

Closed

6 tasks

Snuffleupagus reviewed Oct 4, 2013
View reviewed changes

timvandermeij added 5 commits March 13, 2014 23:16

Making src/core/image.js adhere to the style guide

a2e80f0

Making src/core/obj.js adhere to the style guide

7a73f81

Making src/core/parser.js adhere to the style guide

b45c1f8

Merge branch 'master' of git://github.com/mozilla/pdf.js

25f472e

Merge branch 'master' of git://github.com/mozilla/pdf.js

89b24b6

yurydelendik mentioned this pull request Mar 17, 2014

Missing pt-BR translations #4476

Closed

Merge branch 'master' of git://github.com/mozilla/pdf.js

fa6459c

yurydelendik reviewed Mar 20, 2014
View reviewed changes

timvandermeij changed the title ~~Import l10n files from mozilla-aurora~~ [WIP] Import l10n files from mozilla-aurora Mar 20, 2014

Snuffleupagus reviewed Mar 21, 2014
View reviewed changes

timvandermeij changed the title ~~[WIP] Import l10n files from mozilla-aurora~~ Import l10n files from mozilla-aurora [WIP] Mar 22, 2014

timvandermeij added 5 commits March 22, 2014 15:21

Import l10n files from mozilla-aurora

4c77cd3

Removing languages not present in mozilla-aurora: they will be replac…

10462b3

…ed with the proper language codes

Importing all locales from mozilla-aurora: keeping our own metadata.i…

151cdf3

…nc files

Moving import logic to 'external' folder and updated CONTRIBUTING.md …

eaedcd6

…and README.md

Merging

5d7fafa

timvandermeij closed this Mar 22, 2014

timvandermeij deleted the l10n-import-makefile branch March 22, 2014 16:16

timvandermeij mentioned this pull request Mar 22, 2014

Import l10n files from mozilla-aurora #4504

Merged

Snuffleupagus mentioned this pull request Jul 8, 2018

[Regression] The gulp locale command prints "Skipping invalid locale: ja-JP-mac" warnings on every invocation #9878

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Import l10n files from mozilla-aurora [WIP] #3766

Import l10n files from mozilla-aurora [WIP] #3766

timvandermeij commented Oct 3, 2013

Snuffleupagus Oct 4, 2013

timvandermeij Oct 4, 2013

waddlesplash commented Oct 17, 2013

yurydelendik commented Mar 17, 2014

Snuffleupagus commented Mar 17, 2014

yurydelendik commented Mar 17, 2014

Snuffleupagus commented Mar 17, 2014

timvandermeij commented Mar 18, 2014

yurydelendik commented Mar 18, 2014

yurydelendik Mar 20, 2014

yurydelendik Mar 20, 2014

yurydelendik commented Mar 20, 2014

Snuffleupagus Mar 21, 2014

timvandermeij Mar 21, 2014

timvandermeij commented Mar 22, 2014

		@@ -0,0 +1 @@
		Most of the files in this folder (except for the `en-US` folder and the `metadata.inc` files) have been imported from the Firefox Aurora branch, which is located at https://mxr.mozilla.org/l10n-mozilla-aurora/source. Those files are licensed under the MPL license. You can obtain a copy of the license at http://mozilla.org/MPL/2.0.

Import l10n files from mozilla-aurora [WIP] #3766

Import l10n files from mozilla-aurora [WIP] #3766

Conversation

timvandermeij commented Oct 3, 2013

Snuffleupagus Oct 4, 2013

Choose a reason for hiding this comment

timvandermeij Oct 4, 2013

Choose a reason for hiding this comment

waddlesplash commented Oct 17, 2013

yurydelendik commented Mar 17, 2014

Snuffleupagus commented Mar 17, 2014

yurydelendik commented Mar 17, 2014

Snuffleupagus commented Mar 17, 2014

timvandermeij commented Mar 18, 2014

yurydelendik commented Mar 18, 2014

yurydelendik Mar 20, 2014

Choose a reason for hiding this comment

yurydelendik Mar 20, 2014

Choose a reason for hiding this comment

yurydelendik commented Mar 20, 2014

Snuffleupagus Mar 21, 2014

Choose a reason for hiding this comment

timvandermeij Mar 21, 2014

Choose a reason for hiding this comment

timvandermeij commented Mar 22, 2014